-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
domain: fix stats worker cannot recover from panic #9072
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #9072 +/- ##
==========================================
+ Coverage 67.17% 67.21% +0.03%
==========================================
Files 372 372
Lines 76642 76642
==========================================
+ Hits 51484 51512 +28
+ Misses 20554 20523 -31
- Partials 4604 4607 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
Stats worker cannot recover from panic correctly.
What is changed and how it works?
Change the call to
recoverInDomain
in a stand-alone function.Check List
Tests
Code changes
Side effects
Related changes