Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

domain: fix stats worker cannot recover from panic #9072

Merged
merged 2 commits into from
Jan 15, 2019

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Jan 15, 2019

What problem does this PR solve?

Stats worker cannot recover from panic correctly.

What is changed and how it works?

Change the call to recoverInDomain in a stand-alone function.

Check List

Tests

  • Unit test

Code changes

  • Has unexported function/method change

Side effects

  • None

Related changes

  • Need to cherry-pick to the release branch

@alivxxx alivxxx added the type/bugfix This PR fixes a bug. label Jan 15, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx
Copy link
Contributor Author

alivxxx commented Jan 15, 2019

/run-all-tests

@alivxxx alivxxx added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 15, 2019
@codecov-io
Copy link

codecov-io commented Jan 15, 2019

Codecov Report

Merging #9072 into master will increase coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9072      +/-   ##
==========================================
+ Coverage   67.17%   67.21%   +0.03%     
==========================================
  Files         372      372              
  Lines       76642    76642              
==========================================
+ Hits        51484    51512      +28     
+ Misses      20554    20523      -31     
- Partials     4604     4607       +3
Impacted Files Coverage Δ
domain/domain.go 40.67% <66.66%> (+4.97%) ⬆️
executor/executor.go 67.08% <0%> (-0.29%) ⬇️
executor/join.go 78.44% <0%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2d349c...b1cdd91. Read the comment docs.

Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 15, 2019
@eurekaka eurekaka merged commit cb43fc9 into pingcap:master Jan 15, 2019
alivxxx added a commit to alivxxx/tidb that referenced this pull request Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants