Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: support JSON return type in case expression (#8355) #9109

Merged
merged 3 commits into from
Jan 24, 2019
Merged

expression: support JSON return type in case expression (#8355) #9109

merged 3 commits into from
Jan 24, 2019

Conversation

eurekaka
Copy link
Contributor

cherry-pick #8355

@eurekaka eurekaka added type/enhancement The issue or PR belongs to an enhancement. component/expression labels Jan 17, 2019
winoros
winoros reviewed Jan 17, 2019
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eurekaka
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@eurekaka eurekaka added status/LGT1 Indicates that a PR has LGTM 1. status/all tests passed labels Jan 17, 2019
zz-jason
zz-jason approved these changes Jan 23, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 23, 2019
@ngaut ngaut merged commit 1dadf30 into pingcap:release-2.1 Jan 24, 2019
@eurekaka eurekaka deleted the case_json branch January 24, 2019 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros left review comments

@zz-jason zz-jason zz-jason approved these changes

Assignees
No one assigned
Labels
component/expression status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eurekaka @zz-jason @winoros @ngaut