Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: resolve the charset by the order: table->database->server (#9105) #9147

Merged
merged 3 commits into from
Jan 23, 2019
Merged

ddl: resolve the charset by the order: table->database->server (#9105) #9147

merged 3 commits into from
Jan 23, 2019

Conversation

winkyao
Copy link
Contributor

@winkyao winkyao commented Jan 22, 2019

What problem does this PR solve?

cherry-pick from #9105

Copy link
Contributor

@ciscoxll ciscoxll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ciscoxll ciscoxll added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 22, 2019
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 23, 2019
@zimulala
Copy link
Contributor

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

@winkyao
Copy link
Contributor Author

winkyao commented Jan 23, 2019

/run-all-tests tidb-test=pr/730 tidb-private-test=release-2.1 tikv=release-2.1

@winkyao
Copy link
Contributor Author

winkyao commented Jan 23, 2019

/run-all-tests tidb-test=pr/730 tidb-private-test=release-2.1 tikv=release-2.1

@winkyao winkyao merged commit e659e1d into pingcap:release-2.1 Jan 23, 2019
@winkyao winkyao deleted the cherry-pick-2.1 branch January 23, 2019 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants