Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: support JSON for builtin function COALESCE (#9087) #9198

Merged
merged 1 commit into from
Jan 28, 2019
Merged

expression: support JSON for builtin function COALESCE (#9087) #9198

merged 1 commit into from
Jan 28, 2019

Conversation

zz-jason
Copy link
Member

cherry pick #9087 to release-2.1

@zz-jason
Copy link
Member Author

/run-all-tests tikv=release-2.1 pd=release-2.1 tidb-test=release-2.1

eurekaka
eurekaka reviewed Jan 28, 2019
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 28, 2019
XuHuaiyu
XuHuaiyu approved these changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit 721193c into pingcap:release-2.1 Jan 28, 2019
@zz-jason zz-jason deleted the cherrpick/2.1-coalesce-json branch January 28, 2019 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eurekaka eurekaka eurekaka left review comments

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

Assignees
No one assigned
Labels
component/expression status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zz-jason @eurekaka @XuHuaiyu