-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: support "show create user" #9240
Conversation
# Conflicts: # go.mod # go.sum
# Conflicts: # go.mod # go.sum # planner/core/planbuilder.go
@lnhote Thanks! |
@lnhote Thank you for working on this! It looks like it just needs
|
Thanks for the help. Please take another look. |
Codecov Report
@@ Coverage Diff @@
## master #9240 +/- ##
==========================================
+ Coverage 67.02% 67.15% +0.13%
==========================================
Files 373 373
Lines 78150 78191 +41
==========================================
+ Hits 52378 52512 +134
+ Misses 21094 20977 -117
- Partials 4678 4702 +24
Continue to review full report at Codecov.
|
@lnhote can you please add tests for:
I am getting the following behavior on a fresh install. Both are different results from MySQL:
|
Expected behavior:
|
# Conflicts: # privilege/privileges/privileges.go
@lnhote I left two review comments. It looks good otherwise. Thanks! |
LGTM |
@lnhote please resolve conflicts. |
@morgo PTAL. |
LGTM |
executor/show_test.go
Outdated
@@ -16,13 +16,13 @@ package executor_test | |||
import ( | |||
"context" | |||
"fmt" | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not remove this line, keep the sys libs separate with the 3rd party libs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding the blank line will cause check_dev to fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why check_dev could pass in master branch? I think you've added a blank line with some white spaces, try to keep it as it used to be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed it.
/run-all-tests |
/run-integration-common-test |
/run-integration-ddl-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
Support SHOW CREATE USER as in MySQL 5.7.
fix #7733
What is changed and how it works?
Check List
Tests
Code changes