Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: remove constant sort items after substitution #9333

Merged
merged 5 commits into from
Feb 18, 2019

Conversation

zz-jason
Copy link
Member

What problem does this PR solve?

fix #9331

What is changed and how it works?

remove remove meaningless constant sort items after column substitution.

Check List

Tests

  • Integration test

Related changes

  • Need to cherry-pick to the release branch

@zz-jason zz-jason added priority/P1 The issue has P1 priority. type/bugfix This PR fixes a bug. sig/planner SIG: Planner labels Feb 17, 2019
@zz-jason
Copy link
Member Author

/run-all-tests

@zz-jason
Copy link
Member Author

This PR fixes the broken integration tests, please review it in a high priority.

@codecov-io
Copy link

codecov-io commented Feb 17, 2019

Codecov Report

Merging #9333 into master will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9333      +/-   ##
==========================================
+ Coverage   67.21%   67.22%   +<.01%     
==========================================
  Files         371      371              
  Lines       77552    77556       +4     
==========================================
+ Hits        52125    52134       +9     
+ Misses      20772    20771       -1     
+ Partials     4655     4651       -4
Impacted Files Coverage Δ
planner/core/rule_topn_push_down.go 92.68% <50%> (-2.19%) ⬇️
store/tikv/scan.go 73.94% <0%> (-3.37%) ⬇️
expression/schema.go 93.75% <0%> (-0.79%) ⬇️
executor/join.go 78.9% <0%> (+0.52%) ⬆️
infoschema/infoschema.go 77.63% <0%> (+1.31%) ⬆️
ddl/delete_range.go 79.36% <0%> (+4.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d09e0e3...fc42294. Read the comment docs.

XuHuaiyu
XuHuaiyu previously approved these changes Feb 18, 2019
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu XuHuaiyu dismissed their stale review February 18, 2019 02:39

only 1 LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 18, 2019
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 18, 2019
@eurekaka eurekaka merged commit c468f02 into pingcap:master Feb 18, 2019
@zz-jason zz-jason deleted the bugfix/remore-constant-sort-item branch February 18, 2019 02:57
zz-jason added a commit to zz-jason/tidb that referenced this pull request Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/P1 The issue has P1 priority. sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

assertion failed on order by items
4 participants