Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: show tidb_force_priority should be same as config #9342

Merged
merged 5 commits into from
Feb 18, 2019
Merged

config: show tidb_force_priority should be same as config #9342

merged 5 commits into from
Feb 18, 2019

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Feb 18, 2019

What problem does this PR solve?

If the force-priority is set in the config file, it should be the same as the result of select @@session.tidb_force_priority when the user has not set it before.

What is changed and how it works?

Change the default value for tidb_force_priority the same as it is in the config file.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    Change the config file and then start the server.
    Check the result of select @@session.tidb_force_priority.

Code changes

  • Has exported function/method change

Related changes

  • Need to cherry-pick to the release branch

@jackysp jackysp added type/bugfix This PR fixes a bug. component/server labels Feb 18, 2019
@jackysp jackysp requested review from lysu and winkyao February 18, 2019 07:45
@jackysp
Copy link
Member Author

jackysp commented Feb 18, 2019

/run-all-tests

@codecov-io
Copy link

codecov-io commented Feb 18, 2019 •
edited
Loading

Codecov Report

Merging #9342 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9342      +/-   ##
==========================================
+ Coverage   67.18%   67.19%   +0.01%     
==========================================
  Files         371      371              
  Lines       77618    77618              
==========================================
+ Hits        52145    52155      +10     
+ Misses      20810    20804       -6     
+ Partials     4663     4659       -4
Impacted Files Coverage Δ
sessionctx/variable/sysvar.go 100% <ø> (ø) ⬆️
expression/schema.go 93.75% <0%> (-0.79%) ⬇️
executor/distsql.go 72.53% <0%> (-0.47%) ⬇️
executor/join.go 78.38% <0%> (+0.52%) ⬆️
ddl/delete_range.go 79.36% <0%> (+4.23%) ⬆️
util/systimemon/systime_mon.go 100% <0%> (+20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e6ce46...10c5fff. Read the comment docs.

XuHuaiyu
XuHuaiyu reviewed Feb 18, 2019
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that we should set the value as this commit does.

@XuHuaiyu
Copy link
Contributor

#7729

@jackysp
Copy link
Member Author

jackysp commented Feb 18, 2019

It does, see

tidb/tidb-server/main.go

Line 447 in 6136ab1

variable.ForcePriority = int32(mysql.Str2Priority(cfg.Performance.ForcePriority))

zimulala
zimulala reviewed Feb 18, 2019
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added status/LGT1 Indicates that a PR has LGTM 1. status/all tests passed labels Feb 18, 2019
XuHuaiyu
XuHuaiyu previously approved these changes Feb 18, 2019
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp dismissed XuHuaiyu’s stale review February 18, 2019 08:34

Need some checks.

@jackysp
Copy link
Member Author

jackysp commented Feb 18, 2019

PTAL @XuHuaiyu

@XuHuaiyu
Copy link
Contributor

LGTM
PTAL @zimulala

zimulala
zimulala approved these changes Feb 18, 2019
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member Author

jackysp commented Feb 18, 2019

/run-all-tests

winkyao
winkyao reviewed Feb 18, 2019
View reviewed changes
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp merged commit a333cfb into pingcap:master Feb 18, 2019
jackysp added a commit to jackysp/tidb that referenced this pull request Feb 18, 2019
@jackysp
config: show tidb_force_priority should be same as config (pingcap#9342)
b28d614
@jackysp jackysp mentioned this pull request Feb 18, 2019
Merged
zz-jason pushed a commit that referenced this pull request Feb 18, 2019
@jackysp @zz-jason
config: show tidb_force_priority should be same as config (#9342) (#9347
e83737c 
)
@jackysp jackysp deleted the fix_priority branch April 4, 2019 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winkyao winkyao winkyao left review comments

@zimulala zimulala zimulala approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

@lysu lysu Awaiting requested review from lysu

Assignees
No one assigned
Labels
component/server status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jackysp @codecov-io @XuHuaiyu @zimulala @winkyao