Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: add an variable to compatible with MySQL insert for OGG (#7863) #9401

Merged
merged 3 commits into from
Feb 21, 2019
Merged

executor: add an variable to compatible with MySQL insert for OGG (#7863) #9401

merged 3 commits into from
Feb 21, 2019

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Feb 21, 2019

What problem does this PR solve?

Cherry-pick #7863 to release 2.1.

@jackysp
Copy link
Member Author

jackysp commented Feb 21, 2019

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

zimulala
zimulala reviewed Feb 21, 2019
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 21, 2019
imtbkcat
imtbkcat approved these changes Feb 21, 2019
View reviewed changes
Copy link

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imtbkcat imtbkcat added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 21, 2019
@jackysp jackysp merged commit 687d52a into pingcap:release-2.1 Feb 21, 2019
jackysp added a commit to jackysp/tidb that referenced this pull request Feb 28, 2019
@jackysp
executor: add an variable to compatible with MySQL insert for OGG (pi…
965aa36 
…ngcap#7863) (pingcap#9401)
@jackysp jackysp mentioned this pull request Feb 28, 2019
Closed
@jackysp jackysp deleted the comp_2.1 branch April 4, 2019 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala left review comments

@imtbkcat imtbkcat imtbkcat approved these changes

@lysu lysu Awaiting requested review from lysu

Assignees
No one assigned
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackysp @zimulala @imtbkcat