Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: refactor builtin function RAND to be compatible with MySQL (#9387) #9446

Merged
merged 2 commits into from
Feb 25, 2019
Merged

expression: refactor builtin function RAND to be compatible with MySQL (#9387) #9446

merged 2 commits into from
Feb 25, 2019

Conversation

XuHuaiyu
Copy link
Contributor

cherry-pick #9387

@zz-jason
Copy link
Member

LGTM

@zz-jason
Copy link
Member

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 25, 2019
alivxxx
alivxxx approved these changes Feb 25, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 25, 2019
@ngaut ngaut merged commit 225421b into pingcap:release-2.1 Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alivxxx alivxxx alivxxx approved these changes

@winoros winoros Awaiting requested review from winoros

Assignees
No one assigned
Labels
component/expression status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XuHuaiyu @zz-jason @alivxxx @ngaut