-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: support window function rank and dense_rank #9500
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9500 +/- ##
==========================================
- Coverage 67.42% 67.37% -0.06%
==========================================
Files 373 374 +1
Lines 78568 78620 +52
==========================================
- Hits 52976 52969 -7
- Misses 20837 20892 +55
- Partials 4755 4759 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
/run-integration-compatibility-test |
What problem does this PR solve?
Support window function rank and dense_rank.
See https://dev.mysql.com/doc/refman/8.0/en/window-function-descriptions.html#function_rank and https://dev.mysql.com/doc/refman/8.0/en/window-function-descriptions.html#function_dense-rank
For #9499
What is changed and how it works?
Implement the function using the agg function interface.
Check List
Tests
Code changes
Side effects
Related changes