-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: check no partitions error when create partition table #9531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #9531 +/- ##
=============================================
+ Coverage 67.38% 67.3951% +0.015%
=============================================
Files 374 374
Lines 78921 78936 +15
=============================================
+ Hits 53177 53199 +22
+ Misses 20991 20987 -4
+ Partials 4753 4750 -3 |
/run-all-tests |
LGTM |
zimulala
reviewed
Mar 6, 2019
zimulala
reviewed
Mar 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zimulala
added
status/LGT2
Indicates that a PR has LGTM 2.
and removed
status/LGT1
Indicates that a PR has LGTM 1.
labels
Mar 6, 2019
winkyao
approved these changes
Mar 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
crazycs520
added a commit
to crazycs520/tidb
that referenced
this pull request
Mar 12, 2019
winkyao
pushed a commit
that referenced
this pull request
Mar 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
sig/sql-infra
SIG: SQL Infra
status/LGT2
Indicates that a PR has LGTM 2.
type/bugfix
This PR fixes a bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
In MySQL
But in TiDB will execute those sql successful. then add index in this no partition table will panic.
Other check, drop partition will have check if drop the last partition and return
ErrDropLastPartition
, so drop partition will not cause the no partition table problem.What is changed and how it works?
Add check when create partition table.
Check List
Tests
Code changes
Side effects
Related changes