tidb: Split datasource name to uri and dbName #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DBName may be different from data path name.
| name = name[len("file://"):] | ||
| case strings.HasPrefix(name, "memory://"): | ||
| name = name[len("memory://"):] | ||
| case strings.HasPrefix(uri, "file://"): |
There was a problem hiding this comment.
does any engine use file:// as the prefix ?
There was a problem hiding this comment.
The switch statement is useless now. I will remove it.
|
PTAL |
|
LGTM |
shenli
added a commit
that referenced
this pull request
Sep 10, 2015
tidb: Split datasource name to uri and dbName
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
1. Ensure FileCheckpointsDB is mutex-protected. This prevents the "concurrent map iteration and map write" error. 2. Split the DDLs creating a MySQLCheckpointsDB into 3 separate statements 3. Reduced the path length of chunks_v3 in the PRIMARY KEY to 500 chars to avoid the 3072 key-length limitation.
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
Signed-off-by: Neil Shen <[email protected]>
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Sep 28, 2021
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Oct 8, 2021
ti-chi-bot
pushed a commit
that referenced
this pull request
Oct 9, 2021
hawkingrei
pushed a commit
to hawkingrei/tidb
that referenced
this pull request
May 31, 2022
mittalrishabh
pushed a commit
to mittalrishabh/tidb
that referenced
this pull request
May 30, 2024
…#53335) (pingcap#96) * *: add rpc error stats and refine log for diagnose (pingcap#53335) * sessionctx: add sysvar to control exp feats of replica selector Signed-off-by: zyguan <[email protected]> * *: add rpc error stats and refine log (pingcap#52810) Signed-off-by: crazycs520 <[email protected]> * store: refine coprocessor error log (pingcap#52729) Signed-off-by: crazycs520 <[email protected]> * *: improve log about stale-read query (pingcap#52494) Signed-off-by: crazycs520 <[email protected]> * *: refine tikv/client-go log to print context information(such as conn id) as much as possible (pingcap#45559) Signed-off-by: crazycs520 <[email protected]> * add leader peer id log Signed-off-by: crazycs520 <[email protected]> * update log Signed-off-by: crazycs520 <[email protected]> * executor: fix issue that some query execution stats was omitted when execution was interrupted (pingcap#51787) close pingcap#51660 Signed-off-by: crazycs520 <[email protected]> * update go.mod Signed-off-by: crazycs520 <[email protected]> --------- Signed-off-by: zyguan <[email protected]> Signed-off-by: crazycs520 <[email protected]> Co-authored-by: zyguan <[email protected]> * Update go.sum * Update go.mod --------- Signed-off-by: zyguan <[email protected]> Signed-off-by: crazycs520 <[email protected]> Co-authored-by: crazycs <[email protected]> Co-authored-by: zyguan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DBName may be different from data path name.