statistics: set correlation when loading needed column histogram #9701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9701 +/- ##
================================================
+ Coverage 67.3428% 67.3543% +0.0114%
================================================
Files 378 378
Lines 79514 79542 +28
================================================
+ Hits 53547 53575 +28
+ Misses 21192 21191 -1
- Partials 4775 4776 +1 |
|
/run-all-tests |
zz-jason
added
status/LGT2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #9700
What is changed and how it works?
RCA: column is marked as needed by the explain query, so the histogram would be built in
LoadNeedHistograms, which does not set correlation field properly. Later inupdateStatsWorker, it finds that column is not nil, so it would not build a new one, thus the correlation of column has no chance to be updated anymore.Set correlation using the one queried from storage initially in
LoadNeededHistograms.Check List
Tests
Code changes
Side effects
N/A
Related changes
N/A