Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHANGELOG: add release notes for v2.1.6 #9747

Merged
merged 6 commits into from
Mar 15, 2019
Merged

CHANGELOG: add release notes for v2.1.6 #9747

merged 6 commits into from
Mar 15, 2019

Conversation

winkyao
Copy link
Contributor

@winkyao winkyao commented Mar 15, 2019

What problem does this PR solve?

Add release notes for v2.1.6

@jackysp @zz-jason PTAL

zz-jason
zz-jason reviewed Mar 15, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jackysp
jackysp reviewed Mar 15, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
jackysp
jackysp reviewed Mar 15, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
jackysp
jackysp reviewed Mar 15, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
dcalvin
dcalvin reviewed Mar 15, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
dcalvin
dcalvin reviewed Mar 15, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
dcalvin
dcalvin reviewed Mar 15, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
dcalvin
dcalvin reviewed Mar 15, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
dcalvin
dcalvin reviewed Mar 15, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
dcalvin
dcalvin reviewed Mar 15, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
dcalvin
dcalvin reviewed Mar 15, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
jackysp and others added 3 commits March 15, 2019 15:14
@winkyao
Copy link
Contributor Author

winkyao commented Mar 15, 2019

@jacksp @dcalvin PTAL

dcalvin
dcalvin reviewed Mar 15, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
dcalvin
dcalvin reviewed Mar 15, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
dcalvin
dcalvin reviewed Mar 15, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
dcalvin
dcalvin reviewed Mar 15, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
dcalvin
dcalvin reviewed Mar 15, 2019
View reviewed changes
Copy link
Contributor

@dcalvin dcalvin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some further language edits because of network latency. @winkyao PTAL and batch apply.

@CLAassistant
Copy link

CLAassistant commented Mar 15, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@winkyao
Copy link
Contributor Author

winkyao commented Mar 15, 2019

@dcalvin, please signed the CLA

@dcalvin
Copy link
Contributor

dcalvin commented Mar 15, 2019

@dcalvin, please signed the CLA

done!

dcalvin
dcalvin reviewed Mar 15, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@dcalvin @winkyao
Update CHANGELOG.md
4540fcf 
Co-Authored-By: winkyao <[email protected]>
jackysp
jackysp approved these changes Mar 15, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp merged commit 66e639e into pingcap:release-2.1 Mar 15, 2019
@dcalvin
Copy link
Contributor

dcalvin commented Mar 15, 2019

LGTM now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@dcalvin dcalvin dcalvin left review comments

@jackysp jackysp jackysp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@winkyao @CLAassistant @dcalvin @jackysp @zz-jason