Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore FULLTEXT KEYs in CREATE TABLE statements. #9786

Closed
wants to merge 1 commit into from
Closed

Conversation

kolbe
Copy link
Contributor

@kolbe kolbe commented Mar 18, 2019

What problem does this PR solve?

#3658

What is changed and how it works?

FULLTEXT KEY in CREATE TABLE is ignored.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

@CLAassistant
Copy link

CLAassistant commented Mar 18, 2019

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Mar 18, 2019

Codecov Report

Merging #9786 into master will decrease coverage by 0.0058%.
The diff coverage is 0%.

@@               Coverage Diff                @@
##             master      #9786        +/-   ##
================================================
- Coverage   67.2278%   67.2219%   -0.0059%     
================================================
  Files           381        381                
  Lines         79839      79843         +4     
================================================
- Hits          53674      53672         -2     
- Misses        21379      21384         +5     
- Partials       4786       4787         +1

@kolbe
Copy link
Contributor Author

kolbe commented Mar 18, 2019

Closing; will create a new PR coming from a fork rather than branch.

@kolbe kolbe closed this Mar 18, 2019
@kolbe kolbe deleted the kolbe-fulltext branch March 18, 2019 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants