Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

domain,owner: unify and normalize the format of the log (#9646)(#10012) #9953

Merged
merged 7 commits into from
Apr 4, 2019
Merged

domain,owner: unify and normalize the format of the log (#9646)(#10012) #9953

merged 7 commits into from
Apr 4, 2019

Conversation

xiekeyi98
Copy link
Contributor

@xiekeyi98 xiekeyi98 commented Mar 29, 2019 •
edited
Loading

What problem does this PR solve?

Cherry-pick from #9646 and #10012 ( bug fix for #9646)
Unify and normalize the format of the log.

What is changed and how it works?

Use the new library to log.

Check List

Tests

  • Unit test
  • Integration test

This change is Reviewable

@xiekeyi98
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

@xiekeyi98
Copy link
Contributor Author

Wait #9659 to be cherry-picked.

@zz-jason
Copy link
Member

zz-jason commented Apr 2, 2019

@xiekeyi98 #9659 is merged, please fix ci.

@xiekeyi98
Copy link
Contributor Author

@zz-jason I'm waiting for #9659 to be cherry-picked.
Indeed, I'm waiting for #9955 merged.

@xiekeyi98
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

@xiekeyi98 xiekeyi98 changed the title [WIP]domain,owner: unify and normalize the format of the log (#9646) domain,owner: unify and normalize the format of the log (#9646) Apr 3, 2019
@xiekeyi98 xiekeyi98 changed the title domain,owner: unify and normalize the format of the log (#9646) domain,owner: unify and normalize the format of the log (#9646)(#10012) Apr 3, 2019
@xiekeyi98
Copy link
Contributor Author

/run-all-tests tidb-test=pr/775 tidb-private-test=release-2.1 tikv=release-2.1

@xiekeyi98
Copy link
Contributor Author

/run-all-tests tidb-test=pr/775 tidb-private-test=release-2.1 tikv=release-2.1

eurekaka
eurekaka reviewed Apr 4, 2019
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added status/all tests passed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 4, 2019
zz-jason
zz-jason approved these changes Apr 4, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 4, 2019
@zz-jason zz-jason merged commit 1dba727 into pingcap:release-2.1 Apr 4, 2019
@xiekeyi98 xiekeyi98 deleted the cherryPick-log-domain branch April 4, 2019 03:47
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eurekaka eurekaka eurekaka left review comments

@zz-jason zz-jason zz-jason approved these changes

Assignees
No one assigned
Labels
contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xiekeyi98 @zz-jason @eurekaka @sre-bot