Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] planner,privilege: Support column level privileges #9956

Closed
wants to merge 3 commits into from

Conversation

erjiaqing
Copy link
Contributor

What problem does this PR solve?

implement #9766

What is changed and how it works?

Removed old privilege checks and add checks for column level privileges.

Check List

Tests

TODO

Code changes

  • Column level privileges (select, update and insert) is supported.

Side effects

  • Possible performance regression

The code might be slower since we need to check column level privileges instead of just check table level privileges.

Maybe we can mark this as optional, that is, provide a flag, if some one need it, just set it to true and we will check column level privileges.

Related changes

TODO

@zz-jason
Copy link
Member

zz-jason commented Aug 3, 2019

@erjiaqing friendly ping, any update?

@sre-bot
Copy link
Contributor

sre-bot commented Aug 3, 2019

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@zz-jason
Copy link
Member

I'm going to close this PR due to outdated, fell free to reopen it if you are going to process it again in the future.

@zz-jason zz-jason closed this Aug 25, 2019
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/privilege contribution This PR is from a community contributor. type/new-feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants