Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression, types: fix str_to_date func compatible (#9819) #9964

Merged
merged 1 commit into from
Apr 1, 2019

Conversation

b41sh
Copy link
Member

@b41sh b41sh commented Mar 31, 2019

What problem does this PR solve?

Cherry-pick from #9819

fix str_to_date func compatible

What is changed and how it works?

keep format '%H' without '%p'

Check List

Tests

  • Unit test
  • Integration test

@zz-jason
Copy link
Member

zz-jason commented Apr 1, 2019

LGTM

@zz-jason zz-jason added status/LGT1 Indicates that a PR has LGTM 1. contribution This PR is from a community contributor. component/expression type/2.1 cherry-pick labels Apr 1, 2019
@zz-jason
Copy link
Member

zz-jason commented Apr 1, 2019

/run-all-tests tidb-test=release-2.1 pd=release-2.1 tikv=release-2.1

@zz-jason zz-jason requested a review from XuHuaiyu April 1, 2019 02:34
@qw4990 qw4990 self-requested a review April 1, 2019 02:36
@XuHuaiyu XuHuaiyu changed the title fix str_to_date func compatible (#9819) expression, types: fix str_to_date func compatible (#9819) Apr 1, 2019
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 1, 2019
@zz-jason
Copy link
Member

zz-jason commented Apr 1, 2019

/run-integration-common-test tidb-test=release-2.1 pd=release-2.1 tikv=release-2.1

@zz-jason
Copy link
Member

zz-jason commented Apr 1, 2019

/run-unit-test tidb-test=release-2.1 pd=release-2.1 tikv=release-2.1

@zz-jason zz-jason merged commit 92096dd into pingcap:release-2.1 Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants