Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: kill tidb [session id] can't stop executors and release resources quickly #9976

Merged
merged 5 commits into from
Apr 4, 2019
Merged

executor: kill tidb [session id] can't stop executors and release resources quickly #9976

merged 5 commits into from
Apr 4, 2019

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Apr 1, 2019

cherry-pick for #9844

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 1, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

zz-jason
zz-jason reviewed Apr 1, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason
Copy link
Member

zz-jason commented Apr 1, 2019

@qw4990 build failed:


+ make

CGO_ENABLED=1 GO111MODULE=on go build   -ldflags '-X "github.com/pingcap/parser/mysql.TiDBReleaseVersion=v2.1.7-15-g893111b323" -X "github.com/pingcap/tidb/util/printer.TiDBBuildTS=2019-04-01 12:06:58" -X "github.com/pingcap/tidb/util/printer.TiDBGitHash=893111b323494e5089182d67561388677160b9e8" -X "github.com/pingcap/tidb/util/printer.TiDBGitBranch=HEAD" -X "github.com/pingcap/tidb/util/printer.GoVersion=go version go1.11.2 linux/amd64" ' -o bin/tidb-server tidb-server/main.go

# github.com/pingcap/tidb/server

server/server.go:370:4: undefined: logutil

server/server.go:370:19: undefined: context

server/server.go:370:73: undefined: zap

make: *** [server] Error 2

script returned exit code 2

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 1, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 1, 2019

It seems that we have to wait for #9955

@xiekeyi98
Copy link
Contributor

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@zz-jason zz-jason added status/all tests passed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 4, 2019
lysu
lysu approved these changes Apr 4, 2019
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 4, 2019
@zz-jason zz-jason merged commit ce3744a into pingcap:release-2.1 Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@lysu lysu lysu approved these changes

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qw4990 @zz-jason @xiekeyi98 @lysu @jackysp