address comments

Signed-off-by: Lloyd-Pottiger <[email protected]>
pingcap · Aug 22, 2024 · ec80dec · ec80dec
1 parent 4900a90
commit ec80dec
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 6 deletions.
diff --git a/dbms/src/Interpreters/Context.cpp b/dbms/src/Interpreters/Context.cpp
@@ -1385,7 +1385,7 @@ void Context::dropMinMaxIndexCache() const
 {
     auto lock = getLock();
     if (shared->minmax_index_cache)
-        shared->minmax_index_cache.reset();
+        shared->minmax_index_cache->reset();
 }
 
 void Context::setVectorIndexCache(size_t cache_entities)

diff --git a/dbms/src/Storages/DeltaMerge/ScanContext.h b/dbms/src/Storages/DeltaMerge/ScanContext.h
@@ -25,10 +25,6 @@
 
 #include <atomic>
 
-#ifdef __clang__
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wdeprecated-declarations"
-#endif
 
 namespace DB::DM
 {

diff --git a/dbms/src/Storages/S3/FileCache.cpp b/dbms/src/Storages/S3/FileCache.cpp
@@ -262,7 +262,7 @@ FileSegmentPtr FileCache::getOrWait(const S3::S3FilenameView & s3_fname, const s
     {
         // Space not enough.
         GET_METRIC(tiflash_storage_remote_cache, type_dtfile_full).Increment();
-        LOG_DEBUG(
+        LOG_INFO(
             log,
             "s3_key={} space not enough(capacity={} used={} estimzted_size={}), skip cache",
             s3_key,