Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dayofweek and dayofyear in TiFlash #4150

Closed
windtalker opened this issue Feb 28, 2022 · 0 comments · Fixed by #4222
Closed

Support dayofweek and dayofyear in TiFlash #4150

windtalker opened this issue Feb 28, 2022 · 0 comments · Fixed by #4222
Assignees
@gengliqi
Labels
type/feature-request Categorizes issue or PR as related to a new feature.

Comments

@windtalker
Copy link
Contributor

Feature Request

Is your feature request related to a problem? Please describe:

Describe the feature you'd like:

MySQL doc:
https://dev.mysql.com/doc/refman/8.0/en/date-and-time-functions.html#function_dayofweek
https://dev.mysql.com/doc/refman/8.0/en/date-and-time-functions.html#function_dayofyear
TiDB implementation:
https://github.com/pingcap/tidb/blob/f0d83522692cc196b6ad8eeb1e6ea650a5a88667/expression/builtin_time.go#L1274
https://github.com/pingcap/tidb/blob/f0d83522692cc196b6ad8eeb1e6ea650a5a88667/expression/builtin_time.go#L1316
Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gengliqi gengliqi

Labels
type/feature-request Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support dayofweek and dayofyear pushdown to tiflash
2 participants
@windtalker @gengliqi