Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPP tasks may leak threads forever #4238

Closed
bestwoody opened this issue Mar 12, 2022 · 0 comments · Fixed by #4241
Closed

MPP tasks may leak threads forever #4238

bestwoody opened this issue Mar 12, 2022 · 0 comments · Fixed by #4241
Labels
affects-5.0 affects-5.1 affects-5.2 affects-5.3 affects-5.4 severity/major type/bug The issue is confirmed as a bug.

Comments

@bestwoody
Copy link
Contributor

bestwoody commented Mar 12, 2022 •
edited
Loading

Bug Report

MPP tasks may leak threads forever

1. Minimal reproduce step (Required)

1.Do a lot of query between multiple TIFlash nodes.
2. Kill a TiFlash process at the same time.
3.use pstack to find that MppTunnel and its consumer will not be closed as expected when MppTunnel received cancel request before consumer connects it. You can also print some log to find that.

2. What did you expect to see? (Required)

MppTunnel and its consumer will be closed as expected when MppTunnel received cancel request before consumer connects it.

3. What did you see instead (Required)

MppTunnel and its consumer did not be closed as expected when MppTunnel received cancel request before consumer connects it.

4. What is your TiFlash version? (Required)

6.0.0 alpha
@bestwoody bestwoody added the type/bug The issue is confirmed as a bug. label Mar 12, 2022
@bestwoody bestwoody changed the title MppTunnel and its consumer will not be closed as expected when MppTunnel received cancel request before consumer connects it. MppTunnel and its consumer will not be closed as expected ocasionally when cancel Mar 14, 2022
@bestwoody bestwoody mentioned this issue Mar 14, 2022
Merged
12 tasks
@bestwoody bestwoody changed the title MppTunnel and its consumer will not be closed as expected ocasionally when cancel MPP tasks may leak threads forever Mar 14, 2022
ti-chi-bot pushed a commit that referenced this issue Mar 15, 2022
@bestwoody
Fix a bug that MPP tasks may leak threads forever (#4241)
b3a2cd5 
close #4238
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this issue Mar 17, 2022
@bestwoody @JaySon-Huang
Fix a bug that MPP tasks may leak threads forever (pingcap#4241)
d647dfd 
close pingcap#4238
@ti-chi-bot ti-chi-bot mentioned this issue Apr 13, 2022
Merged
12 tasks
This was referenced Apr 13, 2022
Merged
Merged
Merged
Merged
windtalker pushed a commit to windtalker/tiflash that referenced this issue Apr 14, 2022
@bestwoody @windtalker
Fix a bug that MPP tasks may leak threads forever (pingcap#4241)
bc89030 
close pingcap#4238
@windtalker windtalker mentioned this issue Apr 14, 2022
Merged
12 tasks
windtalker added a commit that referenced this issue Apr 14, 2022
@windtalker @bestwoody
Fix a bug that MPP tasks may leak threads forever (#4241) (#4658)
8d110f5 
close #4238

Co-authored-by: bestwoody <[email protected]>
ti-chi-bot added a commit that referenced this issue Apr 14, 2022
@ti-chi-bot
Fix a bug that MPP tasks may leak threads forever (#4241) (#4644)
92566c4 
close #4238
ti-chi-bot added a commit that referenced this issue Apr 14, 2022
@ti-chi-bot
Fix a bug that MPP tasks may leak threads forever (#4241) (#4642)
32bd9b7 
close #4238
ti-chi-bot added a commit that referenced this issue Jun 15, 2022
@ti-chi-bot
Fix a bug that MPP tasks may leak threads forever (#4241) (#4643)
030d05b 
close #4238
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-5.0 affects-5.1 affects-5.2 affects-5.3 affects-5.4 severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix a bug that MPP tasks may leak threads forever
3 participants
@windtalker @ti-chi-bot @bestwoody