Add coprocessor support in TiFlash #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix cop test regression * address comments * format code
* fix cop test regression * address comments * format code * fix npe for dag execute * format code * address comment * add some comments
|
/run-integration-tests |
birdstorm
reviewed
Oct 11, 2019
* fix mutex contention * add const ref
|
lidezhu
reviewed
Oct 12, 2019
lidezhu
reviewed
Oct 15, 2019
* 1. remove duplicate agg funcs, 2. for column ref expr, change column_id to column_index since the value stored in column ref expr is not column id * bug fix
| required_columns.push_back(pk_handle_col->get().name); | ||
| auto pair = storage->getColumns().getPhysical(pk_handle_col->get().name); | ||
| source_columns.push_back(pair); | ||
| is_ts_column.push_back(false); |
There was a problem hiding this comment.
If pk_handle_col->get().tp is TiDB::TypeTimestamp, this chould be true?
There was a problem hiding this comment.
No, timestamp col will never be pk handle col
|
/run-integration-tests |
3 similar comments
|
/run-integration-tests |
|
/run-integration-tests |
|
/run-integration-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.