Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flash-473 optimize date and datetime comparison #221

Merged
merged 6 commits into from
Sep 5, 2019
Merged

Flash-473 optimize date and datetime comparison #221

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0311d57
support udf like with 3 arguments
windtalker Aug 30, 2019
79a0c0f
address comments
windtalker Sep 2, 2019
a5f05ea
add some comments
windtalker Sep 2, 2019
972d545
Merge branch 'cop' of https://github.com/pingcap/tics into like_3arg
windtalker Sep 4, 2019
9c0bd3e
Flash-473 optimize date and datetime comparison
windtalker Sep 4, 2019
02a7d18
address comments
windtalker Sep 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 54 additions & 22 deletions dbms/src/Functions/FunctionsComparison.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,15 @@ inline time_t dateToDateTime(UInt32 date_data)
return DateLUT::instance().makeDateTime(local_date.year(), local_date.month(), local_date.day(), 0, 0, 0);
}

inline DayNum_t dateTimeToDate(time_t time_data, bool & truncated)
zanmato1984 marked this conversation as resolved.
Show resolved Hide resolved
{
// todo use timezone info
auto & date_lut = DateLUT::instance();
truncated = date_lut.toHour(time_data) != 0 || date_lut.toMinute(time_data) != 0 || date_lut.toSecond(time_data) != 0;
auto values = date_lut.getValues(time_data);
return date_lut.makeDayNum(values.year, values.month, values.day_of_month);
}


template <typename A, typename B, template <typename, typename> class Op, bool is_left_date>
struct DateDateTimeComparisonImpl
Expand Down Expand Up @@ -175,18 +184,30 @@ struct DateDateTimeComparisonImpl
}
else
{
using OpType = B;
size_t size = a.size();
const A * a_pos = &a[0];
UInt8 * c_pos = &c[0];
const A * a_end = a_pos + size;

while (a_pos < a_end)
// date vector with datetime constant
// first check if datetime constant can be convert to date constant
bool truncated = true;
DayNum_t date_num = dateTimeToDate((time_t) b, truncated);
if (!truncated)
{
time_t date_time = dateToDateTime(*a_pos);
*c_pos = Op<OpType, OpType>::apply((OpType)date_time, b);
++a_pos;
++c_pos;
using OpType = A;
NumComparisonImpl<OpType, OpType, Op<OpType, OpType>>::vector_constant(a, (OpType) date_num, c);
}
else
{
using OpType = B;
size_t size = a.size();
const A *a_pos = &a[0];
UInt8 *c_pos = &c[0];
const A *a_end = a_pos + size;

while (a_pos < a_end)
{
time_t date_time = dateToDateTime(*a_pos);
*c_pos = Op<OpType, OpType>::apply((OpType) date_time, b);
++a_pos;
++c_pos;
}
}
}
}
Expand All @@ -202,18 +223,29 @@ struct DateDateTimeComparisonImpl
}
else
{
using OpType = A;
size_t size = b.size();
const B * b_pos = &b[0];
UInt8 * c_pos = &c[0];
const B * b_end = b_pos + size;

while (b_pos < b_end)
// datetime constant with date vector
bool truncated = true;
DayNum_t date_num = dateTimeToDate((time_t) a, truncated);
if (!truncated)
{
time_t date_time = dateToDateTime(*b_pos);
*c_pos = Op<OpType, OpType>::apply(a, (OpType)date_time);
++b_pos;
++c_pos;
using OpType = B;
NumComparisonImpl<OpType, OpType, Op<OpType, OpType>>::vector_constant((OpType)a, date_num, c);
}
else
{
using OpType = A;
size_t size = b.size();
const B *b_pos = &b[0];
UInt8 *c_pos = &c[0];
const B *b_end = b_pos + size;

while (b_pos < b_end)
{
time_t date_time = dateToDateTime(*b_pos);
*c_pos = Op<OpType, OpType>::apply(a, (OpType) date_time);
++b_pos;
++c_pos;
}
}
}
}
Expand Down