Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColumnDecimal.cpp: auto => auto & #236

Merged
merged 2 commits into from
Sep 17, 2019
Merged

Conversation

flowbehappy
Copy link
Contributor

@flowbehappy flowbehappy commented Sep 16, 2019

With previous version, each time we call compareAt of ColumnDecimal, we will copy the whole rhs, which is awful.

Copy link
Member

@hanfei1991 hanfei1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JaySon-Huang
Copy link
Contributor

/run-integration-tests

@JaySon-Huang
Copy link
Contributor

/run-integration-tests

@JaySon-Huang JaySon-Huang merged commit a23f3e5 into master Sep 17, 2019
@JaySon-Huang JaySon-Huang deleted the bugfix_auto_to_auto_ref branch September 17, 2019 14:27
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Aug 2, 2024
JaySon-Huang pushed a commit that referenced this pull request Aug 6, 2024
Lloyd-Pottiger pushed a commit to Lloyd-Pottiger/tiflash that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants