Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jemalloc memory profiling (part 1) #3291

Merged
merged 6 commits into from
Oct 26, 2021

Conversation

JaySon-Huang
Copy link
Contributor

What problem does this PR solve?

Issue Number: related to #3236

Problem Summary: Add options for building TiFlash with jemalloc memory profiling enabled.

What is changed and how it works?

  • Add ENABLE_JEMALLOC_PROF for building TiFlash with jemalloc memory profiling enabled, but set it to false by default (This PR can not resolve the issue that TiFlash get stuck occasionally when mem-profiling is enabled && actived)
  • Add a "Welcome to TiFlash" when starting TiFlash, keep same behavior as TiKV/TiDB/PD
  • Add a "Enable Features: " message for TiFlash version info

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

Release note

None

@JaySon-Huang JaySon-Huang added the type/enhancement The issue or PR belongs to an enhancement. label Oct 26, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 26, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • solotzg

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@JaySon-Huang JaySon-Huang self-assigned this Oct 26, 2021
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 26, 2021
Signed-off-by: JaySon-Huang <[email protected]>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 26, 2021
@JaySon-Huang
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8bab7c4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 26, 2021
@ti-chi-bot ti-chi-bot merged commit cf0dc6b into pingcap:master Oct 26, 2021
@JaySon-Huang JaySon-Huang deleted the add_mem_prof-1 branch October 26, 2021 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants