-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metrics: support multi-k8s in grafana dashboards (#4099) #4213
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: just1900 <[email protected]>
Signed-off-by: just1900 <[email protected]>
08e0fea
to
59dddbb
Compare
/merge |
@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 0827ad7
|
@just1900: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
lines: 43.4% (50187 out of 115559) |
What problem does this PR solve?
resolve conflicts when cherry-pick #4099, and this is a continuation of #4206 to bypass repo permission restrictions.
Issue Number: ref #4129
Problem Summary:
K8s community and organizations are increasingly deploying multiple Kubernetes clusters to improve availability, isolation and scalability. Since TiDB Operator have support deploying tidb across-kubernetes, this PR will address the multi-k8s issue without affecting existing single-cluster use case.
What is changed and how it works?
What's Changed:
add a k8s_cluster label in all expr
add k8s_cluster variable in Grafana templating
How it works:
For users with single-k8s, nothing need to be changed, just use it as before.
For users with multi-k8s:
Check List
Tests
Side effects
Documentation
Release note