Fix randomly build failed because mpp.pb.h not found

[guo-shaoge]

Signed-off-by: guo-shaoge [email protected]

What problem does this PR solve?

Issue Number: close #4318

Problem Summary: As issue said, got compilation error. Introduced by #4183. clickhouse_common_io need mpp.pb.h, but doesn't add kvproto as its dependency.

How to reproduce this problem:

1. git clone tiflash repo && git submodule update --init --recursive
2. mkdir build && cd build
3. cmake .. -DCMAKE_BUILD_TYPE=RELWITHDEBINFO -DENABLE_TESTING=OFF -DENABLE_TESTS=OFF -Wno-dev -DUSE_CCACHE=OFF -DRUN_HAVE_STD_REGEX=0 -GNinja . Make sure use ninja, I cannot reproduce with make
4. ninja tiflash -j40. Make sure use high job concurrency.

What is changed and how it works?

1. MyTime.cpp(clickhouse_common_io) includes FunctionsDatetime.h
2. FunctionsDatetime.h includes DAGContext.h.(Added by support last_day and dayofmonth pushdown to tiflash #4183)
3. DAGContext.h includes mpp.pb.h

Remove the dependency of MyTime.cpp on FunctionsDatetime.h, which is more reasonable. So clickhouse_common_io will not depend on kvproto.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Fix randomly build failed because mpp.pb.h not found

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• fuzhe1989
• windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[guo-shaoge]

/run-check-issue-triage-complete

[guo-shaoge]

For DB::toString()

[windtalker]

LGTM

[zanmato1984]

LGTM

[guo-shaoge]

/merge

[ti-chi-bot]

@guo-shaoge: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: a3bc0c5

[sre-bot]

Coverage for changed files

Filename                          Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/MyTime.cpp                    1048               206    80.34%         112                25    77.68%        2153               518    75.94%         920               256    72.17%
Common/MyTime.h                        22                 0   100.00%           9                 0   100.00%          30                 0   100.00%          16                 3    81.25%
Functions/FunctionsDateTime.h        1031               628    39.09%         322               211    34.47%        1942              1196    38.41%         498               324    34.94%
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                2101               834    60.30%         443               236    46.73%        4125              1714    58.45%        1434               583    59.34%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16975      9546             43.76%    191250  96878        49.34%

full coverage report (for internal network access only)

[ti-chi-bot]

In response to a cherrypick label: cannot checkout release-6.0: error checking out release-6.0: exit status 1. output: error: pathspec 'release-6.0' did not match any file(s) known to git

[guo-shaoge]

In response to a cherrypick label: cannot checkout release-6.0: error checking out release-6.0: exit status 1. output: error: pathspec 'release-6.0' did not match any file(s) known to git

Already in release-6.0, no need to cherry pick.