Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scheduler no throw in destruction and avoid updated min-tso query hang (#4367) #4399

Merged
merged 6 commits into from
Mar 24, 2022
Merged

Scheduler no throw in destruction and avoid updated min-tso query hang (#4367) #4399

merged 6 commits into from
Mar 24, 2022

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4367

Signed-off-by: fzhedu [email protected]

What problem does this PR solve?

Issue Number: close #4366

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Mar 23, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • windtalker
  • zanmato1984

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 23, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 23, 2022
Merged
12 tasks
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.0 labels Mar 23, 2022
windtalker
windtalker approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 23, 2022
zanmato1984
zanmato1984 approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Mar 24, 2022
@VelocityLight
Copy link

/merge

@ti-chi-bot
Copy link
Member Author

@VelocityLight: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

@VelocityLight: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@fzhedu
Copy link
Contributor

fzhedu commented Mar 24, 2022

/merge

@ti-chi-bot
Copy link
Member Author

@fzhedu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

@fzhedu: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@zanmato1984
Copy link
Contributor

/lgtm

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 24, 2022

Coverage for changed files

Filename                                          Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
dbms/src/Flash/Mpp/MPPTask.cpp                        415               415     0.00%          21                21     0.00%         348               348     0.00%         188               188     0.00%
dbms/src/Flash/Mpp/MPPTask.h                            3                 3     0.00%           3                 3     0.00%           3                 3     0.00%           0                 0         -
dbms/src/Flash/Mpp/MPPTaskManager.cpp                  98                97     1.02%          12                11     8.33%         176               175     0.57%          70                70     0.00%
dbms/src/Flash/Mpp/MinTSOScheduler.cpp                306               273    10.78%           7                 6    14.29%         183               161    12.02%         148               143     3.38%
dbms/src/Flash/Mpp/MinTSOScheduler.h                    4                 1    75.00%           2                 0   100.00%           4                 0   100.00%           4                 3    25.00%
libs/libcommon/include/common/logger_useful.h          12                 0   100.00%           4                 0   100.00%          15                 3    80.00%           6                 0   100.00%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                 838               789     5.85%          49                41    16.33%         729               690     5.35%         416               404     2.88%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16975      9540             43.80%    191297  96856        49.37%

full coverage report (for internal network access only)

zanmato1984
zanmato1984 approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 24, 2022
@zanmato1984
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

@zanmato1984: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 515bff1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 24, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 24, 2022

Coverage for changed files

Filename                                          Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
dbms/src/Flash/Mpp/MPPTask.cpp                        415               415     0.00%          21                21     0.00%         348               348     0.00%         188               188     0.00%
dbms/src/Flash/Mpp/MPPTask.h                            3                 3     0.00%           3                 3     0.00%           3                 3     0.00%           0                 0         -
dbms/src/Flash/Mpp/MPPTaskManager.cpp                  98                97     1.02%          12                11     8.33%         176               175     0.57%          70                70     0.00%
dbms/src/Flash/Mpp/MinTSOScheduler.cpp                306               273    10.78%           7                 6    14.29%         183               161    12.02%         148               143     3.38%
dbms/src/Flash/Mpp/MinTSOScheduler.h                    4                 1    75.00%           2                 0   100.00%           4                 0   100.00%           4                 3    25.00%
libs/libcommon/include/common/logger_useful.h          12                 0   100.00%           4                 0   100.00%          15                 3    80.00%           6                 1    83.33%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                 838               789     5.85%          49                41    16.33%         729               690     5.35%         416               405     2.64%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16975      9540             43.80%    191297  96847        49.37%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 1dd5d6c into pingcap:release-6.0 Mar 24, 2022
@JaySon-Huang JaySon-Huang added this to the v6.0.0 milestone Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker approved these changes

@zanmato1984 zanmato1984 zanmato1984 approved these changes

@fuzhe1989 fuzhe1989 Awaiting requested review from fuzhe1989

@bestwoody bestwoody Awaiting requested review from bestwoody

Assignees

@fzhedu fzhedu

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.0
Projects
None yet
Milestone
v6.0.0
Development

Successfully merging this pull request may close these issues.
7 participants
@ti-chi-bot @VelocityLight @fzhedu @zanmato1984 @sre-bot @windtalker @JaySon-Huang