Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clear old range before apply snapshot #4668

Merged
merged 3 commits into from
Apr 20, 2022

Conversation

lidezhu
Copy link
Contributor

@lidezhu lidezhu commented Apr 14, 2022

What problem does this PR solve?

Issue Number: close #4414

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  1. load data into tidb cluster with multiple tiflash nodes by import csv file and set tiflash replica to 1;
  2. set tiflash replica to 0 and see whether the data can be reclaimed;

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Avoid leaving data on tiflash node which doesn't corresponding to any region range

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 14, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CalvinNeo
  • gengliqi

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-cherry-pick-release-4.0 PR which needs to be cherry-picked to release-4.0 needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 needs-cherry-pick-release-5.1 PR which needs to be cherry-picked to release-5.1 needs-cherry-pick-release-5.2 PR which needs to be cherry-picked to release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 Type: Need cherry pick to release-6.0 and removed do-not-merge/needs-linked-issue labels Apr 14, 2022
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 15, 2022
@lidezhu lidezhu changed the title [WIP] clear old range before apply snapshot clear old range before apply snapshot Apr 15, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 15, 2022
@lidezhu lidezhu requested a review from gengliqi April 15, 2022 04:00
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 15, 2022
@lidezhu
Copy link
Contributor Author

lidezhu commented Apr 20, 2022

/merge

@ti-chi-bot
Copy link
Member

@lidezhu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2c71faa

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 20, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Apr 20, 2022

Coverage for changed files

Filename                                                                                                       Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Storages/Transaction/ApplySnapshot.cpp         336               155    53.87%          13                 4    69.23%         478               223    53.35%         166               104    37.35%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                              336               155    53.87%          13                 4    69.23%         478               223    53.35%         166               104    37.35%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17132      9492             44.59%    192860  96261        50.09%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Apr 20, 2022
@ti-chi-bot ti-chi-bot merged commit 7149736 into pingcap:master Apr 20, 2022
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Apr 20, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4714.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Apr 20, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4715.

@lidezhu lidezhu deleted the fix-not-gc-data branch April 20, 2022 04:47
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4716.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4717.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4718.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Apr 20, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4719.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Apr 20, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4720.

@sre-bot
Copy link
Collaborator

sre-bot commented Apr 20, 2022

Coverage for changed files

Filename                                                                                                       Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Storages/Transaction/ApplySnapshot.cpp         336               155    53.87%          13                 4    69.23%         478               223    53.35%         166               104    37.35%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                              336               155    53.87%          13                 4    69.23%         478               223    53.35%         166               104    37.35%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17132      9492             44.59%    192860  96275        50.08%

full coverage report (for internal network access only)

@lidezhu lidezhu removed the needs-cherry-pick-release-4.0 PR which needs to be cherry-picked to release-4.0 label Apr 20, 2022
ti-chi-bot added a commit that referenced this pull request Apr 20, 2022
ti-chi-bot added a commit that referenced this pull request Jun 2, 2022
ti-chi-bot added a commit that referenced this pull request Jun 2, 2022
ti-chi-bot added a commit that referenced this pull request Jun 2, 2022
ti-chi-bot added a commit that referenced this pull request Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 needs-cherry-pick-release-5.1 PR which needs to be cherry-picked to release-5.1 needs-cherry-pick-release-5.2 PR which needs to be cherry-picked to release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 Type: Need cherry pick to release-6.0 release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TiFlash can't gc totally after set tiflash replica 0
5 participants