-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update TiFlash proxy to raftstore-proxy-6.0 for up(down)grade test #4748
Conversation
Signed-off-by: CalvinNeo <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/cc @solotzg @flowbehappy |
/run-all-tests |
Coverage for changed files
Coverage summary
full coverage report (for internal network access only) |
/cc @jiaqizho |
/merge |
@CalvinNeo: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 2170b0f
|
Coverage for changed files
Coverage summary
full coverage report (for internal network access only) |
/run-all-tests |
Coverage for changed files
Coverage summary
full coverage report (for internal network access only) |
In my M1 Pro I experienced compiling error since this PR:
However I can compile successfully in TiKV master branch. Do you have any ideas? |
Signed-off-by: CalvinNeo [email protected]
What problem does this PR solve?
Issue Number: ref #4618
Problem Summary:
Though we have already passed all test cases, we still have to check whether there are problems when TiFlash is updated from any versions to versions using proxy 6.0, before we merge PR pingcap/tidb-engine-ext#55.
As the automated procedure to do this needs new proxy be used by TiFlash at master branch, so we have this PR.
After this test is completed, we will then merge proxy's PR to the main branch, thus redirect TiFlash's proxy to main branch.
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note