Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update TiFlash proxy to raftstore-proxy-6.0 for up(down)grade test #4748

Merged
merged 2 commits into from
Apr 25, 2022

Conversation

CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented Apr 25, 2022

Signed-off-by: CalvinNeo [email protected]

What problem does this PR solve?

Issue Number: ref #4618

Problem Summary:

Though we have already passed all test cases, we still have to check whether there are problems when TiFlash is updated from any versions to versions using proxy 6.0, before we merge PR pingcap/tidb-engine-ext#55.

As the automated procedure to do this needs new proxy be used by TiFlash at master branch, so we have this PR.

After this test is completed, we will then merge proxy's PR to the main branch, thus redirect TiFlash's proxy to main branch.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 25, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • jiaqizho
  • solotzg

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 25, 2022
@CalvinNeo
Copy link
Member Author

/cc @solotzg @flowbehappy

@CalvinNeo
Copy link
Member Author

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Apr 25, 2022

Coverage for changed files

no c/c++ source change detected

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17250      9408             45.46%    194273  95797        50.69%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 25, 2022
@CalvinNeo
Copy link
Member Author

/cc @jiaqizho

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 25, 2022
@CalvinNeo
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

@CalvinNeo: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2170b0f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 25, 2022
@CalvinNeo CalvinNeo changed the title update TiFlash proxy to raftstore-proxy-6.0 update TiFlash proxy to raftstore-proxy-6.0 for up(down)grade test Apr 25, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Apr 25, 2022

Coverage for changed files

no c/c++ source change detected

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17250      9408             45.46%    194273  95784        50.70%

full coverage report (for internal network access only)

@CalvinNeo
Copy link
Member Author

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Apr 25, 2022

Coverage for changed files

no c/c++ source change detected

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17257      9415             45.44%    194309  95819        50.69%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 1bbe1b0 into pingcap:master Apr 25, 2022
@breezewish
Copy link
Member

In my M1 Pro I experienced compiling error since this PR:

= note: ld: warning: directory not found for option '-L/Users/breezewish/Work/tiflash/contrib/tiflash-proxy/target/debug/build/libz-sys-981451fd99e28b0e/out/build'
          Undefined symbols for architecture arm64:
            "_SSL_get_peer_certificate", referenced from:
                ssl_handshaker_result_extract_peer(tsi_handshaker_result const*, tsi_peer*) in libgrpcio_sys-57002017520551a2.rlib(ssl_transport_security.cc.o)
          ld: symbol(s) not found for architecture arm64
          clang: error: linker command failed with exit code 1 (use -v to see invocation)

However I can compile successfully in TiKV master branch. Do you have any ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants