Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support weekofyear pushdown to tiflash #4791

Merged
merged 7 commits into from
May 2, 2022

Conversation

gengliqi
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #4677

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Support weekofyear pushdown to tiflash

Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 28, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • guo-shaoge
  • yibin87

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 28, 2022
Signed-off-by: gengliqi <[email protected]>
@ywqzzy ywqzzy self-requested a review April 28, 2022 08:28
@gengliqi
Copy link
Contributor Author

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Apr 28, 2022

Coverage for changed files

Filename                                 Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/Coprocessor/DAGUtils.cpp               351               219    37.61%          44                18    59.09%         628               388    38.22%         416               250    39.90%
Functions/FunctionsDateTime.cpp               27                19    29.63%           4                 2    50.00%         102                25    75.49%          16                13    18.75%
Functions/FunctionsDateTime.h               1041               628    39.67%         324               211    34.88%        1963              1196    39.07%         504               325    35.52%
Functions/tests/gtest_weekofyear.cpp         130                37    71.54%           1                 0   100.00%          76                 0   100.00%          40                21    47.50%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                       1549               903    41.70%         373               231    38.07%        2769              1609    41.89%         976               609    37.60%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18056      10148            43.80%    200127  100907       49.58%

full coverage report (for internal network access only)

Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 29, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 29, 2022
@gengliqi
Copy link
Contributor Author

gengliqi commented May 2, 2022

/merge

@ti-chi-bot
Copy link
Member

@gengliqi: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d5f6d2e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 2, 2022
@ti-chi-bot
Copy link
Member

@gengliqi: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented May 2, 2022

Coverage for changed files

Filename                                 Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/Coprocessor/DAGUtils.cpp               351               219    37.61%          44                18    59.09%         628               388    38.22%         416               250    39.90%
Functions/FunctionsDateTime.cpp               27                19    29.63%           4                 2    50.00%         102                25    75.49%          16                13    18.75%
Functions/FunctionsDateTime.h               1041               628    39.67%         324               211    34.88%        1963              1196    39.07%         504               325    35.52%
Functions/tests/gtest_weekofyear.cpp         130                37    71.54%           1                 0   100.00%          76                 0   100.00%          40                21    47.50%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                       1549               903    41.70%         373               231    38.07%        2769              1609    41.89%         976               609    37.60%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18061      10147            43.82%    200234  100914       49.60%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 934b3d5 into pingcap:master May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support weekofyear in TiFlash
6 participants