Add to_seconds support for tiflash #4866

yibin87 · 2022-05-11T13:59:05Z

Signed-off-by: yibin [email protected]

What problem does this PR solve?

Issue Number: close #4679

Problem Summary:

What is changed and how it works?

Check List

Tests

[ x ] Unit test
[ x ] Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

None

Signed-off-by: yibin <[email protected]>

ti-chi-bot · 2022-05-11T13:59:06Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

guo-shaoge
windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

yibin87 · 2022-05-13T01:21:33Z

/run-all-tests

sre-bot · 2022-05-13T01:52:12Z

Coverage for changed files

Filename                                Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/MyTime.cpp                          1058               184    82.61%         113                24    78.76%        2163               493    77.21%         926               239    74.19%
Common/MyTime.h                              22                 0   100.00%           9                 0   100.00%          30                 0   100.00%          16                 3    81.25%
Flash/Coprocessor/DAGUtils.cpp              351               213    39.32%          44                17    61.36%         628               383    39.01%         416               247    40.62%
Functions/FunctionsDateTime.cpp              27                19    29.63%           4                 2    50.00%         103                25    75.73%          16                13    18.75%
Functions/FunctionsDateTime.h              1051               628    40.25%         326               211    35.28%        1984              1196    39.72%         510               326    36.08%
Functions/tests/gtest_toseconds.cpp         130                37    71.54%           1                 0   100.00%          57                 0   100.00%          40                21    47.50%
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                      2639              1081    59.04%         497               254    48.89%        4965              2097    57.76%        1924               849    55.87%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18102      9851             45.58%    201793  98356        51.26%

full coverage report (for internal network access only)

windtalker · 2022-05-13T03:04:24Z

dbms/src/Functions/FunctionsDateTime.h

+
+    static ToFieldType execute(const Context & context, const MyTimeBase & val, bool & is_null)
+    {
+        // TiDB returns normal value if one of month/day is zero for to_seconds function, while MySQL return null if either of them is zero.


Seems a TiDB bug, please fire a issue for this.

OK，I'll fire one later.

pingcap/tidb#34629

windtalker

LGTM

Signed-off-by: yibin <[email protected]>

yibin87 · 2022-05-13T05:15:40Z

/merge

ti-chi-bot · 2022-05-13T05:15:41Z

@yibin87: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2022-05-13T05:15:42Z

This pull request has been accepted and is ready to merge.

Commit hash: 16a39ee

sre-bot · 2022-05-13T05:45:43Z

Coverage for changed files

Filename                                Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/MyTime.cpp                          1058               184    82.61%         113                24    78.76%        2163               493    77.21%         926               239    74.19%
Common/MyTime.h                              22                 0   100.00%           9                 0   100.00%          30                 0   100.00%          16                 3    81.25%
Flash/Coprocessor/DAGUtils.cpp              351               213    39.32%          44                17    61.36%         628               383    39.01%         416               247    40.62%
Functions/FunctionsDateTime.cpp              27                19    29.63%           4                 2    50.00%         103                25    75.73%          16                13    18.75%
Functions/FunctionsDateTime.h              1051               628    40.25%         326               211    35.28%        1984              1196    39.72%         510               326    36.08%
Functions/tests/gtest_toseconds.cpp         130                37    71.54%           1                 0   100.00%          57                 0   100.00%          40                21    47.50%
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                      2639              1081    59.04%         497               254    48.89%        4965              2097    57.76%        1924               849    55.87%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18125      9785             46.01%    202275  97854        51.62%

full coverage report (for internal network access only)

sre-bot · 2022-05-13T05:48:54Z

Coverage for changed files

Filename                                Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/MyTime.cpp                          1058               184    82.61%         113                24    78.76%        2163               493    77.21%         926               239    74.19%
Common/MyTime.h                              22                 0   100.00%           9                 0   100.00%          30                 0   100.00%          16                 3    81.25%
Flash/Coprocessor/DAGUtils.cpp              351               213    39.32%          44                17    61.36%         628               383    39.01%         416               247    40.62%
Functions/FunctionsDateTime.cpp              27                19    29.63%           4                 2    50.00%         103                25    75.73%          16                13    18.75%
Functions/FunctionsDateTime.h              1051               628    40.25%         326               211    35.28%        1984              1196    39.72%         510               326    36.08%
Functions/tests/gtest_toseconds.cpp         130                37    71.54%           1                 0   100.00%          57                 0   100.00%          40                21    47.50%
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                      2639              1081    59.04%         497               254    48.89%        4965              2097    57.76%        1924               849    55.87%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18102      9851             45.58%    201793  98359        51.26%

full coverage report (for internal network access only)

sre-bot · 2022-05-13T06:29:18Z

Coverage for changed files

Filename                                Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/MyTime.cpp                          1058               184    82.61%         113                24    78.76%        2163               493    77.21%         926               239    74.19%
Common/MyTime.h                              22                 0   100.00%           9                 0   100.00%          30                 0   100.00%          16                 3    81.25%
Flash/Coprocessor/DAGUtils.cpp              351               213    39.32%          44                17    61.36%         628               383    39.01%         416               247    40.62%
Functions/FunctionsDateTime.cpp              27                19    29.63%           4                 2    50.00%         103                25    75.73%          16                13    18.75%
Functions/FunctionsDateTime.h              1051               628    40.25%         326               211    35.28%        1984              1196    39.72%         510               326    36.08%
Functions/tests/gtest_toseconds.cpp         130                37    71.54%           1                 0   100.00%          57                 0   100.00%          40                21    47.50%
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                      2639              1081    59.04%         497               254    48.89%        4965              2097    57.76%        1924               849    55.87%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18125      9785             46.01%    202281  97862        51.62%

full coverage report (for internal network access only)

sre-bot · 2022-05-13T07:23:01Z

Coverage for changed files

Filename                                Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/MyTime.cpp                          1058               184    82.61%         113                24    78.76%        2163               493    77.21%         926               239    74.19%
Common/MyTime.h                              22                 0   100.00%           9                 0   100.00%          30                 0   100.00%          16                 3    81.25%
Flash/Coprocessor/DAGUtils.cpp              351               213    39.32%          44                17    61.36%         628               383    39.01%         416               247    40.62%
Functions/FunctionsDateTime.cpp              27                19    29.63%           4                 2    50.00%         103                25    75.73%          16                13    18.75%
Functions/FunctionsDateTime.h              1051               628    40.25%         326               211    35.28%        1984              1196    39.72%         510               326    36.08%
Functions/tests/gtest_toseconds.cpp         130                37    71.54%           1                 0   100.00%          57                 0   100.00%          40                21    47.50%
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                      2639              1081    59.04%         497               254    48.89%        4965              2097    57.76%        1924               849    55.87%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18125      9786             46.01%    202281  97856        51.62%

full coverage report (for internal network access only)

sre-bot · 2022-05-13T08:23:09Z

Coverage for changed files

Filename                                Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/MyTime.cpp                          1058               184    82.61%         113                24    78.76%        2163               493    77.21%         926               239    74.19%
Common/MyTime.h                              22                 0   100.00%           9                 0   100.00%          30                 0   100.00%          16                 3    81.25%
Flash/Coprocessor/DAGUtils.cpp              351               213    39.32%          44                17    61.36%         628               383    39.01%         416               247    40.62%
Functions/FunctionsDateTime.cpp              27                19    29.63%           4                 2    50.00%         103                25    75.73%          16                13    18.75%
Functions/FunctionsDateTime.h              1051               628    40.25%         326               211    35.28%        1984              1196    39.72%         510               326    36.08%
Functions/tests/gtest_toseconds.cpp         130                37    71.54%           1                 0   100.00%          57                 0   100.00%          40                21    47.50%
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                      2639              1081    59.04%         497               254    48.89%        4965              2097    57.76%        1924               849    55.87%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18125      9786             46.01%    202281  97861        51.62%

full coverage report (for internal network access only)

…ot supported yet Signed-off-by: yibin <[email protected]>

yibin87 · 2022-05-13T08:46:02Z

/merge

ti-chi-bot · 2022-05-13T08:46:03Z

@yibin87: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2022-05-13T08:46:04Z

This pull request has been accepted and is ready to merge.

Commit hash: e4dbeff

ti-chi-bot · 2022-05-13T09:16:46Z

@yibin87: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

sre-bot · 2022-05-13T10:02:49Z

Coverage for changed files

Filename                                Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/MyTime.cpp                          1058               184    82.61%         113                24    78.76%        2163               493    77.21%         926               239    74.19%
Common/MyTime.h                              22                 0   100.00%           9                 0   100.00%          30                 0   100.00%          16                 3    81.25%
Flash/Coprocessor/DAGUtils.cpp              351               213    39.32%          44                17    61.36%         628               383    39.01%         416               247    40.62%
Functions/FunctionsDateTime.cpp              27                19    29.63%           4                 2    50.00%         103                25    75.73%          16                13    18.75%
Functions/FunctionsDateTime.h              1051               628    40.25%         326               211    35.28%        1984              1196    39.72%         510               326    36.08%
Functions/tests/gtest_toseconds.cpp         130                37    71.54%           1                 0   100.00%          57                 0   100.00%          40                21    47.50%
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                      2639              1081    59.04%         497               254    48.89%        4965              2097    57.76%        1924               849    55.87%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18128      9788             46.01%    202355  97915        51.61%

full coverage report (for internal network access only)

Add to_seconds support for tiflash

380e28c

Signed-off-by: yibin <[email protected]>

ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 11, 2022

yibin87 requested review from guo-shaoge, gengliqi and windtalker May 11, 2022 14:00

windtalker reviewed May 13, 2022

View reviewed changes

windtalker approved these changes May 13, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 13, 2022

guo-shaoge approved these changes May 13, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 13, 2022

Fix format issue

16a39ee

Signed-off-by: yibin <[email protected]>

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 13, 2022

Disable the test that is different from tidb when tidb push down is n…

e4dbeff

…ot supported yet Signed-off-by: yibin <[email protected]>

ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label May 13, 2022

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 13, 2022

ti-chi-bot added 2 commits May 13, 2022 16:46

Merge branch 'master' into dev_feature_branch

95baddd

Merge branch 'master' into dev_feature_branch

bad7d14

ti-chi-bot merged commit 9bfb02f into pingcap:master May 13, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add to_seconds support for tiflash #4866

Add to_seconds support for tiflash #4866

yibin87 commented May 11, 2022

ti-chi-bot commented May 11, 2022 •

edited

Loading

yibin87 commented May 13, 2022

sre-bot commented May 13, 2022

windtalker May 13, 2022

yibin87 May 13, 2022

yibin87 May 13, 2022

windtalker left a comment

yibin87 commented May 13, 2022

ti-chi-bot commented May 13, 2022

ti-chi-bot commented May 13, 2022

sre-bot commented May 13, 2022

sre-bot commented May 13, 2022

sre-bot commented May 13, 2022

sre-bot commented May 13, 2022

sre-bot commented May 13, 2022

yibin87 commented May 13, 2022

ti-chi-bot commented May 13, 2022

ti-chi-bot commented May 13, 2022

ti-chi-bot commented May 13, 2022

sre-bot commented May 13, 2022

Add to_seconds support for tiflash #4866

Add to_seconds support for tiflash #4866

Conversation

yibin87 commented May 11, 2022

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented May 11, 2022 • edited Loading

yibin87 commented May 13, 2022

sre-bot commented May 13, 2022

Coverage for changed files

Coverage summary

windtalker May 13, 2022

Choose a reason for hiding this comment

yibin87 May 13, 2022

Choose a reason for hiding this comment

yibin87 May 13, 2022

Choose a reason for hiding this comment

windtalker left a comment

Choose a reason for hiding this comment

yibin87 commented May 13, 2022

ti-chi-bot commented May 13, 2022

ti-chi-bot commented May 13, 2022

sre-bot commented May 13, 2022

Coverage for changed files

Coverage summary

sre-bot commented May 13, 2022

Coverage for changed files

Coverage summary

sre-bot commented May 13, 2022

Coverage for changed files

Coverage summary

sre-bot commented May 13, 2022

Coverage for changed files

Coverage summary

sre-bot commented May 13, 2022

Coverage for changed files

Coverage summary

yibin87 commented May 13, 2022

ti-chi-bot commented May 13, 2022

ti-chi-bot commented May 13, 2022

ti-chi-bot commented May 13, 2022

sre-bot commented May 13, 2022

Coverage for changed files

Coverage summary

ti-chi-bot commented May 11, 2022 •

edited

Loading