Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter lock flag 'F' #7569

Merged
merged 3 commits into from
May 30, 2023
Merged

Filter lock flag 'F' #7569

merged 3 commits into from
May 30, 2023

Conversation

CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented May 30, 2023

What problem does this PR solve?

Issue Number: close #7563

Problem Summary:

Due to pingcap/tidb#43540, tikv propose a fix that introduce a new flag F that shall be filtered by TiFlash.

The new flag is to persist a special state that guides tikv how to resolve locks.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

f
Signed-off-by: CalvinNeo <[email protected]>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 30, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • Lloyd-Pottiger

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 30, 2023
@CalvinNeo
Copy link
Member Author

/cc @pingcap/tiflash-committers

@ti-chi-bot ti-chi-bot bot requested a review from a team May 30, 2023 07:22
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 30, 2023
@CalvinNeo
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 30, 2023

@CalvinNeo: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 30, 2023

This pull request has been accepted and is ready to merge.

Commit hash: ce50ac0

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 30, 2023
@ti-chi-bot ti-chi-bot bot merged commit 8dcb558 into pingcap:master May 30, 2023
@CalvinNeo
Copy link
Member Author

/run-cherry-picker

@CalvinNeo
Copy link
Member Author

/cherry-pick release-7.1

@ti-chi-bot ti-chi-bot mentioned this pull request May 30, 2023
12 tasks
@ti-chi-bot
Copy link
Member

@CalvinNeo: new pull request created to branch release-7.1: #7573.

In response to this:

/cherry-pick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request May 30, 2023
ti-chi-bot bot pushed a commit that referenced this pull request Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TiFlash crash for invalid flag F in lock value
4 participants