Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storages: Refine metrics of read threads and data sharing (#8653) #8660

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #8653

What problem does this PR solve?

Issue Number: ref #8652

What is changed and how it works?

  • Add CPU usage metrics of SegmentReader.
    image

  • Refine metrics of read thread and data sharing.
    image
    image
    image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Jan 3, 2024
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 3, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 19, 2024
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 19, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 19, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 19, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 19, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, JinheLin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,JinheLin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 19, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-19 02:53:40.684608988 +0000 UTC m=+497262.248906694: ☑️ agreed by JaySon-Huang.
  • 2024-01-19 02:56:44.782282023 +0000 UTC m=+497446.346579713: ☑️ agreed by JinheLin.

@JinheLin
Copy link
Contributor

/run-all-tests

@JinheLin
Copy link
Contributor

[2024-01-19T03:11:27.355Z] + docker-compose -f cluster.yaml -f tiflash-dt-async-grpc.yaml down

[2024-01-19T03:11:27.915Z] Stopping tidb-ci_tiflash0_1 ... 

[2024-01-19T03:11:27.915Z] Stopping tidb-ci_tidb0_1    ... 

[2024-01-19T03:11:27.915Z] Stopping tidb-ci_tikv0_1    ... 

[2024-01-19T03:11:27.915Z] Stopping tidb-ci_pd0_1      ... 

[2024-01-19T03:12:39.901Z] 
Stopping tidb-ci_tidb0_1    ... done

Stopping tidb-ci_tikv0_1    ... error

Stopping tidb-ci_pd0_1      ... error


[2024-01-19T03:12:39.901Z] ERROR: for tidb-ci_tiflash0_1  HTTPConnectionPool(host='localhost', port=2375): Read timed out. (read timeout=70)

[2024-01-19T03:12:39.901Z] An HTTP request took too long to complete. Retry with --verbose to obtain debug information.

[2024-01-19T03:12:39.901Z] If you encounter this issue regularly because of slow network conditions, consider setting COMPOSE_HTTP_TIMEOUT to a higher value (current value: 60).

@JinheLin
Copy link
Contributor

/run-integration-test

@ti-chi-bot ti-chi-bot bot merged commit dc93e2b into pingcap:release-6.5 Jan 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants