Storages: Splitting DMFileReaderPool to reduce lock contention #9126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note-none
JaySon-Huang
approved these changes
Jun 6, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
Lloyd-Pottiger
approved these changes
Jun 7, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
ti-chi-bot
added
the
needs-cherry-pick-release-8.1
|
In response to a cherrypick label: new pull request created to branch |
12 tasks
ti-chi-bot
added
the
needs-cherry-pick-release-7.5
|
In response to a cherrypick label: new pull request created to branch |
12 tasks
ti-chi-bot bot
pushed a commit
that referenced
this pull request
Jun 7, 2024
#9129) close #9125 Co-authored-by: jinhelin <[email protected]>
ti-chi-bot bot
added a commit
that referenced
this pull request
Jun 13, 2024
#9130) close #9125 Co-authored-by: jinhelin <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
JaySon-Huang
pushed a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Aug 2, 2024
…ap#9126) (pingcap#9130) close pingcap#9125 Co-authored-by: jinhelin <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot
bot
added
needs-cherry-pick-release-6.5
12 tasks
|
In response to a cherrypick label: new pull request created to branch |
12 tasks
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot bot
pushed a commit
that referenced
this pull request
Aug 27, 2024
#9376) close #9125 Co-authored-by: jinhelin <[email protected]>
ti-chi-bot bot
pushed a commit
that referenced
this pull request
Aug 27, 2024
#9375) close #9125 Co-authored-by: jinhelin <[email protected]> Co-authored-by: JaySon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #9125
Problem Summary:
What is changed and how it works?
Reduce the lock contention on
DMFileReaderPool::mtxby splitting the dmfiles byhash(file_path)of 16Check List
Tests
select max(k) from sbtest1) concurrently.Side effects
Documentation
Release note