Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy: Disable enable_heap_profiling and improve some codes #9247

Closed
wants to merge 8 commits into from

Conversation

CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented Jul 23, 2024

What problem does this PR solve?

Issue Number: ref #9241

Problem Summary:

What is changed and how it works?


Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

CalvinNeo and others added 6 commits July 19, 2024 10:51
Signed-off-by: CalvinNeo <[email protected]>
a
Signed-off-by: CalvinNeo <[email protected]>
a
Signed-off-by: CalvinNeo <[email protected]>
a
Signed-off-by: CalvinNeo <[email protected]>
a
Signed-off-by: CalvinNeo <[email protected]>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Jul 23, 2024
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 23, 2024
@CalvinNeo CalvinNeo changed the title U Disable enable_heap_profiling and improve some codes Jul 23, 2024
@CalvinNeo CalvinNeo changed the title Disable enable_heap_profiling and improve some codes Proxy: Disable enable_heap_profiling and improve some codes Jul 23, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 29, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-29 02:34:34.762245328 +0000 UTC m=+150391.042293396: ☑️ agreed by Lloyd-Pottiger.

@ti-chi-bot ti-chi-bot bot added the approved label Jul 29, 2024
@JaySon-Huang
Copy link
Contributor

Can you add some description about why we need to "Disable enable_heap_profiling"?

@CalvinNeo
Copy link
Member Author

Covered by #9273

@CalvinNeo CalvinNeo closed this Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants