Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storages: Add Block pop-up latency metrics (#9260) #9419

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #9260

What problem does this PR solve?

Issue Number: ref #9417, #6834

Problem Summary:

What is changed and how it works?


  • Block pop-up latency when a query is heavy (sometime it means computing is the bottleneck):
    image

  • Block pop-up latency when a query is light (sometime it means storage is the bottleneck):
    image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Sep 9, 2024
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 9, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 9, 2024
@JinheLin
Copy link
Contributor

JinheLin commented Sep 9, 2024

/run-all-tests

@JinheLin
Copy link
Contributor

JinheLin commented Sep 9, 2024

/run-integration-test

1 similar comment
@JinheLin
Copy link
Contributor

JinheLin commented Sep 9, 2024

/run-integration-test

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 10, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 20, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, JinheLin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,JinheLin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 20, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-10 02:39:03.765955017 +0000 UTC m=+324013.506378970: ☑️ agreed by JinheLin.
  • 2024-09-20 07:58:46.260144705 +0000 UTC m=+1207196.000568625: ☑️ agreed by JaySon-Huang.

@ti-chi-bot ti-chi-bot bot merged commit 7d8b38d into pingcap:release-7.5 Sep 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants