Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storages: add metrics of read thread (#9412) #9421

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Storages: add metrics of read thread (#9412) #9421

merged 2 commits into from
Sep 20, 2024

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #9412

What problem does this PR solve?

Issue Number: ref #9417, #6834

What is changed and how it works?

image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Sep 9, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 9, 2024
Merged
12 tasks
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Sep 9, 2024
@JinheLin JinheLin force-pushed the cherry-pick-9412-to-release-7.5 branch from 44357c8 to 56e7d29 Compare September 20, 2024 08:24
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 20, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 20, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JinheLin, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JinheLin,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 20, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-20 08:24:58.67534595 +0000 UTC m=+1208768.415769874: ☑️ agreed by JinheLin.
  • 2024-09-20 08:27:17.291677963 +0000 UTC m=+1208907.032101901: ☑️ agreed by Lloyd-Pottiger.

@JinheLin
Copy link
Contributor

/run-all-tests

@JinheLin
Copy link
Contributor

/run-integration-test

1 similar comment
@JinheLin
Copy link
Contributor

/run-integration-test

@ti-chi-bot ti-chi-bot bot merged commit 6b739dc into pingcap:release-7.5 Sep 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@JinheLin JinheLin JinheLin approved these changes

@JaySon-Huang JaySon-Huang Awaiting requested review from JaySon-Huang

@CalvinNeo CalvinNeo Awaiting requested review from CalvinNeo

Assignees

@JinheLin JinheLin

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @JinheLin @Lloyd-Pottiger