-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vector: Fix ColumnArray does not work well with CHBlockChunkCodec #9477
vector: Fix ColumnArray does not work well with CHBlockChunkCodec #9477
Conversation
Signed-off-by: JaySon-Huang <[email protected]>
[LGTM Timeline notifier]Timeline:
|
@JaySon-Huang: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests
If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JinheLin, Lloyd-Pottiger, windtalker The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
bfb8ca9
into
pingcap:feature/vector-index
…ngcap#9477) close pingcap#9485 vector: Fix ColumnArray does not work well with CHBlockChunkCodec Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
What problem does this PR solve?
Issue Number: close #9485
Problem Summary:
When MPP tasks exchange data with type
Array(Float32)
,CHBlockChunkDecodeAndSquash
will try to merged the deserialized data into a larger block. ButCHBlockChunkCodec
andCHBlockChunkDecodeAndSquash
seri/deseri the array data withposition_independent_encoding == false
, which cause thecolumn_array.offsets
store incorrect data and causes invalid memory access.What is changed and how it works?
position_independent_encoding == true
inCHBlockChunkCodec
andCHBlockChunkDecodeAndSquash
. So that the array data can be correctly serialized and deserializedDataTypeArray::deserializeBinaryBulkWithMultipleStreams
. If the function is called withposition_independent_encoding == false
, and try to deserialize data into a non-empty column, throw an exceptionCheck List
Tests
Side effects
Documentation
Release note