Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix build on m1 macbook && re-enable clang-tidy checks #9500

Merged
merged 5 commits into from
Sep 30, 2024

Conversation

JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Sep 30, 2024

What problem does this PR solve?

Issue Number: ref #9032

Problem Summary:
clang-tidy is temporary disable to merge the feature branch
#9486 (comment)

What is changed and how it works?


re-enable the clang-tidy checks

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 30, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 30, 2024
@Lloyd-Pottiger
Copy link
Contributor

/hold

I will push a commit to fix arm build later

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2024
Signed-off-by: Lloyd-Pottiger <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 30, 2024
Signed-off-by: Lloyd-Pottiger <[email protected]>
@Lloyd-Pottiger
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JinheLin, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JinheLin,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 30, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 30, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-30 08:28:33.339545779 +0000 UTC m=+257068.759758791: ☑️ agreed by Lloyd-Pottiger.
  • 2024-09-30 10:19:23.096368368 +0000 UTC m=+263718.516581375: ☑️ agreed by JinheLin.

@JaySon-Huang JaySon-Huang changed the title tests: re-enable clang-tidy checks tests: fix build on m1 macbook && re-enable clang-tidy checks Sep 30, 2024
@@ -34,7 +39,9 @@
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wpass-failed"

#if !defined(__APPLE__)
#include <type_traits>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can not build without this include

FAILED: dbms/CMakeFiles/tiflash_vector_search.dir/src/VectorSearch/SIMDFeatures.cpp.o 
/usr/local/bin/ccache /usr/local/bin/clang++ -DFIU_ENABLE -DSERVERLESS_PROXY=0 -DTIFLASH_COMPILER_VPCLMULQDQ_SUPPORT=1 -DTIFLASH_ENABLE_AVX512_SUPPORT=1 -DTIFLASH_ENABLE_AVX_SUPPORT=1 -D_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS -I/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src -isystem /home/jenkins/agent/workspace/tiflash-build-common/tiflash/contrib/usearch/fp16/include -isystem /home/jenkins/agent/workspace/tiflash-build-common/tiflash/contrib/usearch/include -isystem /home/jenkins/agent/workspace/tiflash-build-common/tiflash/contrib/simsimd/include -isystem /home/jenkins/agent/workspace/tiflash-build-common/tiflash/contrib/fmtlib-cmake/../fmtlib/include -Wthread-safety  -pipe -mssse3 -msse4.1 -msse4.2 -mpclmul -mpopcnt  -fno-omit-frame-pointer  -Wall -Wno-unused-command-line-argument  -Wnon-virtual-dtor  -stdlib=libc++ -Wextra -Werror  -O0 -fverbose-asm -fno-inline  -D_LIBCPP_DEBUG=0 -std=gnu++2b -MD -MT dbms/CMakeFiles/tiflash_vector_search.dir/src/VectorSearch/SIMDFeatures.cpp.o -MF dbms/CMakeFiles/tiflash_vector_search.dir/src/VectorSearch/SIMDFeatures.cpp.o.d -o dbms/CMakeFiles/tiflash_vector_search.dir/src/VectorSearch/SIMDFeatures.cpp.o -c /home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/VectorSearch/SIMDFeatures.cpp
In file included from /home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/VectorSearch/SIMDFeatures.cpp:16:
In file included from /home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/VectorSearch/USearch.h:42:
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/contrib/usearch/include/usearch/index.hpp:362:54: error: 'scalar_at' does not refer to a value
  362 |         if (!std::is_trivially_default_constructible<scalar_at>::value)
      |                                                      ^
      /home/jenkins/agent/workspace/tiflash-build-common/tiflash/contrib/usearch/include/usearch/index.hpp:355:20: note: declared here
  355 | template <typename scalar_at, typename allocator_at = std::allocator<scalar_at>> class buffer_gt {
      |                    ^
      /home/jenkins/agent/workspace/tiflash-build-common/tiflash/contrib/usearch/include/usearch/index.hpp:362:19: error: no member named 'is_trivially_default_constructible' in namespace 'std'
  362 |         if (!std::is_trivially_default_constructible<scalar_at>::value)
      |              ~~~~~^
      /home/jenkins/agent/workspace/tiflash-build-common/tiflash/contrib/usearch/include/usearch/index.hpp:362:64: error: no member named 'value' in the global namespace; did you mean 'std::money_base::value'?
  362 |         if (!std::is_trivially_default_constructible<scalar_at>::value)
      |                                                                ^~
      /usr/local/bin/../include/c++/v1/locale:2573:43: note: 'std::money_base::value' declared here
 2573 |     enum part {none, space, symbol, sign, value};
      |          

@ti-chi-bot ti-chi-bot bot merged commit 23f24ac into master Sep 30, 2024
5 checks passed
@ti-chi-bot ti-chi-bot bot deleted the JaySon-Huang-patch-1 branch September 30, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants