Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: Add Thread CPU panel for building vector index #9525

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Oct 14, 2024

What problem does this PR solve?

Issue Number: ref #9032

Problem Summary:

What is changed and how it works?


  • Set the thread name when the thread is executing task of building vector index
  • Add thread CPU panel in the TiFlash-Summary Grafana

image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Add Grafana panel about CPU usage on building vector index

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 14, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 14, 2024
@JaySon-Huang
Copy link
Contributor Author

/test pull-integration-test

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 14, 2024
Copy link
Contributor

ti-chi-bot bot commented Oct 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JinheLin, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JinheLin,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 14, 2024
Copy link
Contributor

ti-chi-bot bot commented Oct 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-14 10:27:23.131791591 +0000 UTC m=+266840.280701415: ☑️ agreed by JinheLin.
  • 2024-10-14 12:18:33.567619351 +0000 UTC m=+273510.716529183: ☑️ agreed by Lloyd-Pottiger.

@Lloyd-Pottiger
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit 463fce3 into pingcap:master Oct 14, 2024
5 checks passed
@JaySon-Huang JaySon-Huang deleted the vector_index_cpu branch October 15, 2024 02:25
JaySon-Huang added a commit to JaySon-Huang/tiflash that referenced this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants