Skip to content

Commit

Permalink
address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
asddongmen committed Nov 1, 2022
1 parent 479a036 commit 82a6fbd
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions cdc/sink/mysql/mysql_syncpoint_store.go
Original file line number Diff line number Diff line change
Expand Up @@ -243,10 +243,12 @@ func (s *mysqlSyncPointStore) SinkSyncPoint(ctx context.Context,
s.syncPointRetention.Seconds())
_, err = tx.Exec(query)
if err != nil {
// It is ok to ignore the error, since clear sync point is not necessary.
// It is ok to ignore the error, since it will not affect the correctness of the system,
// and no any business logic depends on this behavior, so we just log the error.
log.Error("failed to clean syncpoint table", zap.Error(cerror.WrapError(cerror.ErrMySQLTxnError, err)))
} else {
s.lastCleanSyncPointTime = time.Now()
}
s.lastCleanSyncPointTime = time.Now()
}

err = tx.Commit()
Expand Down

0 comments on commit 82a6fbd

Please sign in to comment.