Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ticdc: Recurrence of tar Wildcard Handling Issue in download-integration-test-binaries.sh After Refactor #11631

Closed
wlwilliamx opened this issue Sep 26, 2024 · 0 comments · Fixed by #11632
Assignees
Labels
area/ticdc Issues or PRs related to TiCDC. component/test Unit tests and integration tests component. severity/major type/bug The issue is confirmed as a bug.

Comments

@wlwilliamx
Copy link
Contributor

What did you do?

The issue previously described in #11512 (where tar wildcard handling caused extraction failures in the scripts/download-integration-test-binaries.sh script) has resurfaced after the script was refactored.

During the refactoring, the --wildcards option was not reintroduced, which is required for tar to correctly handle wildcard patterns in some versions. As a result, the script is once again failing to extract the necessary binaries for PD, particularly on systems where tar does not support wildcard patterns by default.

What did you expect to see?

I expected the scripts/download-integration-test-binaries.sh script to successfully extract the PD binaries from the pd-server.tar.gz archive. This would allow the integration tests to run without any errors or missing binaries.

The solution is to reintroduce the --wildcards option in the tar command, as was done in #11513. This ensures compatibility across different environments and versions of tar.

What did you see instead?

The script failed to extract the PD binaries from the pd-server.tar.gz archive due to the missing --wildcards option in the tar command. As a result, the third_bin directory was empty, and the integration tests could not run because the necessary PD executables were missing.
CleanShot 2024-09-26 at 16 13 53@2x

Versions of the cluster

Upstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):

No TiDB.

Upstream TiKV version (execute tikv-server --version):

No TiKV.

TiCDC version (execute cdc version):

v8.3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. component/test Unit tests and integration tests component. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
3 participants