Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unit test workerPoolSuite.TestMultiError is not stable #2469

Closed
amyangfei opened this issue Aug 5, 2021 · 2 comments · Fixed by #2779
Closed

unit test workerPoolSuite.TestMultiError is not stable #2469

amyangfei opened this issue Aug 5, 2021 · 2 comments · Fixed by #2779
Assignees
@Rustin170506
Labels
area/ticdc Issues or PRs related to TiCDC. component/test Unit tests and integration tests component. difficulty/easy Easy task. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. severity/major type/bug The issue is confirmed as a bug.

Comments

@amyangfei
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do? If possible, provide a recipe for reproducing the error.
[2021-08-05T08:15:59.157Z] 
[2021-08-05T08:15:59.157Z] ----------------------------------------------------------------------
[2021-08-05T08:15:59.157Z] FAIL: pool_test.go:115: workerPoolSuite.TestMultiError
[2021-08-05T08:15:59.157Z] 
[2021-08-05T08:15:59.157Z] pool_test.go:137:
[2021-08-05T08:15:59.157Z]     c.Assert(err, check.ErrorMatches, ".*ErrWorkerPoolHandleCancelled.*")
[2021-08-05T08:15:59.157Z] ... error string = "context canceled"
[2021-08-05T08:15:59.157Z] ... regex string = ".*ErrWorkerPoolHandleCancelled.*"
[2021-08-05T08:15:59.157Z] 
[2021-08-05T08:15:59.157Z] OOPS: 15 passed, 1 FAILED
[2021-08-05T08:15:59.157Z] --- FAIL: TestSuite (20.84s)
[2021-08-05T08:15:59.157Z] FAIL
[2021-08-05T08:15:59.157Z] coverage: 94.0% of statements
[2021-08-05T08:15:59.157Z] FAIL	github.com/pingcap/ticdc/pkg/workerpool	20.907s

  1. Versions of the cluster
@amyangfei amyangfei added type/bug The issue is confirmed as a bug. component/test Unit tests and integration tests component. labels Aug 5, 2021
@amyangfei amyangfei mentioned this issue Aug 5, 2021
Closed
@overvenus overvenus self-assigned this Aug 6, 2021
@amyangfei
Copy link
Contributor Author

What about assigning this issue to new colleague @overvenus

@amyangfei amyangfei added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. difficulty/easy Easy task. labels Aug 27, 2021
@Rustin170506
Copy link
Member

This test is failing frequently these days: https://ci2.pingcap.net/blue/organizations/jenkins/cdc_ghpr_test/detail/cdc_ghpr_test/6743/pipeline

Let me try to fix it.

/unassign @overvenus

Hope you don't mind!

/assign

@ti-chi-bot ti-chi-bot assigned Rustin170506 and unassigned overvenus Sep 1, 2021
@Rustin170506 Rustin170506 mentioned this issue Sep 9, 2021
Merged
This was referenced Sep 14, 2021
Merged
Merged
Merged
Merged
@AkiraXie AkiraXie added the area/ticdc Issues or PRs related to TiCDC. label Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rustin170506 Rustin170506

Labels
area/ticdc Issues or PRs related to TiCDC. component/test Unit tests and integration tests component. difficulty/easy Easy task. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix TestTaskError and TestMultiError flaky tests Rustin170506/tiflow
5 participants
@amyangfei @overvenus @jebter @Rustin170506 @AkiraXie