-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix TestTaskError and TestMultiError flaky tests #2779
test: fix TestTaskError and TestMultiError flaky tests #2779
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, could you check if we have handle context canceled
error properly when we call AddEvent
in other files?
/run-integration-tests |
1 similar comment
/run-integration-tests |
/hold |
efc7b4a
to
378adf9
Compare
@overvenus It looks like calls elsewhere will return this error directly. |
@amyangfei @ben1009 I think it ready for review. |
I have tested this many times by limiting resources to 1C locally and it works. |
/unhold |
This pull request has been accepted and is ready to merge. Commit hash: b5fb17d
|
/run-unit-tests |
/run-kafka-tests |
/run-integration-tests |
/run-kafka-tests |
/run-integration-tests |
/run-integration-tests |
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #2779 +/- ##
================================================
+ Coverage 55.3406% 56.8681% +1.5274%
================================================
Files 164 180 +16
Lines 19754 18877 -877
================================================
- Hits 10932 10735 -197
+ Misses 7790 7174 -616
+ Partials 1032 968 -64 |
In response to a cherrypick label: new pull request created: #2817. |
In response to a cherrypick label: new pull request created: #2818. |
In response to a cherrypick label: new pull request created: #2819. |
In response to a cherrypick label: new pull request created: #2820. |
What problem does this PR solve?
close https://github.com/pingcap/ticdc/issues/2469
What is changed and how it works?
In one case, it did happen that isCancelled was used to the next event before it was updated, and ErrCh immediately received an error, just as cancel was called during the execution of AddEvent, which is why I encountered this unstable test. I was able to reproduce the problem occasionally after increasing the number of events and limiting resources locally.
Check List
Tests
Code changes
None
Side effects
None
Related changes
Release note