Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avro: missing tests for column types #3644

Closed
dveeden opened this issue Nov 26, 2021 · 1 comment
Closed

Avro: missing tests for column types #3644

dveeden opened this issue Nov 26, 2021 · 1 comment
Assignees
Labels
area/ticdc Issues or PRs related to TiCDC. severity/moderate type/bug The issue is confirmed as a bug.

Comments

@dveeden
Copy link
Contributor

dveeden commented Nov 26, 2021

What did you do?

#3624 showed issues with the JSON column type and #2648 showed issues with unsigned tinyint. Looking at the tests there seem to be more column types that don't seem to get sufficient testing.

$ grep 'case mysql.Type' avro.go | awk '{ print substr($2,0,length($2)-1) }' | sort -u
mysql.TypeBit
mysql.TypeDate
mysql.TypeDouble
mysql.TypeDuration
mysql.TypeEnum
mysql.TypeFloat
mysql.TypeJSON
mysql.TypeLong
mysql.TypeLonglong
mysql.TypeNewDecimal
mysql.TypeNull
mysql.TypeSet
mysql.TypeTiny
mysql.TypeTinyBlob
mysql.TypeVarchar
mysql.TypeYear
$ grep 'Type: mysql.Type' avro_test.go | sed -E 's/^.*(mysql.Type[a-zA-Z]*).*$/\1 /g' | sort -u
mysql.TypeBlob 
mysql.TypeFloat 
mysql.TypeLong 
mysql.TypeTimestamp 
mysql.TypeTiny 
mysql.TypeVarchar 

What did you expect to see?

No response

What did you see instead?

Versions of the cluster

@dveeden dveeden added type/bug The issue is confirmed as a bug. area/ticdc Issues or PRs related to TiCDC. labels Nov 26, 2021
@zhangyangyu
Copy link
Member

In #5339, I have a UT for every type. But UTs are not very helpful in such situations. I think more IT should be taken into account in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Development

No branches or pull requests

3 participants