Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sink/codec(cdc): refactor Avro codec #5339

Merged
merged 27 commits into from
May 17, 2022
Merged

sink/codec(cdc): refactor Avro codec #5339

merged 27 commits into from
May 17, 2022

Conversation

zhangyangyu
Copy link
Member

@zhangyangyu zhangyangyu commented May 6, 2022 •
edited by Rustin170506
Loading

What problem does this PR solve?

Issue Number: ref #5338

What is changed and how it works?

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 6, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3AceShowHand
  • hi-rustin

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 6, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 6, 2022
@zhangyangyu
Copy link
Member Author

/run-all-tests

@zhangyangyu
Copy link
Member Author

/run-all-tests

@CharlesCheung96 CharlesCheung96 added the area/ticdc Issues or PRs related to TiCDC. label May 6, 2022
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 6, 2022
@zhangyangyu zhangyangyu force-pushed the avro branch 4 times, most recently from ccf36f0 to 826921d Compare May 6, 2022 08:15
@zhaoxinyu
Copy link
Contributor

@zhangyangyu , there are some code conflicts need to be resolved.

@zhangyangyu
Copy link
Member Author

@zhangyangyu , there are some code conflicts need to be resolved.

Still some issues to be resolved, not ready yet. Let me mark it as WIP.

@zhangyangyu zhangyangyu changed the title codec(cdc): make Avro codec GA [WIP] codec(cdc): make Avro codec GA May 6, 2022
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 6, 2022
@zhangyangyu zhangyangyu force-pushed the avro branch 2 times, most recently from ca94957 to ed9cbe7 Compare May 7, 2022 07:49
@zhangyangyu
Copy link
Member Author

/run-all-tests

@zhangyangyu
Copy link
Member Author

/run-all-tests

@zhangyangyu
Copy link
Member Author

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 17, 2022
@zhangyangyu
Copy link
Member Author

/run-dm-compatibility-test

@zhangyangyu
Copy link
Member Author

/run-dm-integration-test

@zhangyangyu zhangyangyu reopened this May 17, 2022
Rustin170506
Rustin170506 approved these changes May 17, 2022
View reviewed changes
pkg/cmd/cli/cli_changefeed_create.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 17, 2022
@Rustin170506
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5a1243b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 17, 2022
@Rustin170506 Rustin170506 changed the title sink/codec(cdc): make Avro codec GA sink/codec(cdc): refactor Avro codec May 17, 2022
@zhangyangyu
Copy link
Member Author

/run-verify

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label May 17, 2022
@Rustin170506
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9301ca6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 17, 2022
@zhangyangyu
Copy link
Member Author

/run-dm-integration-test

@ti-chi-bot ti-chi-bot merged commit c8e7fff into pingcap:master May 17, 2022
sdojjy pushed a commit to sdojjy/tiflow that referenced this pull request May 18, 2022
@zhangyangyu @sdojjy
sink/codec(cdc): refactor Avro codec (pingcap#5339)
e6a313c 
ref pingcap#5338
@zhangyangyu zhangyangyu mentioned this pull request May 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3AceShowHand 3AceShowHand 3AceShowHand approved these changes

@Rustin170506 Rustin170506 Rustin170506 approved these changes

@zhaoxinyu zhaoxinyu Awaiting requested review from zhaoxinyu

@liuzix liuzix Awaiting requested review from liuzix

Assignees
No one assigned
Labels
area/ticdc Issues or PRs related to TiCDC. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@zhangyangyu @ti-chi-bot @zhaoxinyu @codecov-commenter @Rustin170506 @3AceShowHand @CharlesCheung96