Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdc mounter encode default value for unsigned into string, cause canal-json panic. #4635

Closed
Tracked by #4737
3AceShowHand opened this issue Feb 21, 2022 · 0 comments · Fixed by #4629
Closed
Tracked by #4737

cdc mounter encode default value for unsigned into string, cause canal-json panic. #4635

3AceShowHand opened this issue Feb 21, 2022 · 0 comments · Fixed by #4629
Assignees
@3AceShowHand
Labels
affects-5.4 area/ticdc Issues or PRs related to TiCDC. component/sink Sink component. severity/critical type/bug The issue is confirmed as a bug.

Comments

@3AceShowHand
Copy link
Contributor

3AceShowHand commented Feb 21, 2022 •
edited
Loading

What did you do?

The problem is not reproduced yet.

When encoding RowChangedEvent by using the Canal-JSON, it makes the assumption that uint64 will be used for all unsigned SQL type. But it may meet string.

This may be related to #3930

What did you expect to see?

Canal-JSON should handle string for unsigned correctly.

What did you see instead?

CDC server panic.

Versions of the cluster

Upstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):

v5.4.0

Upstream TiKV version (execute tikv-server --version):

v5.4.0

TiCDC version (execute cdc version):

v5.4.0
@3AceShowHand 3AceShowHand added type/bug The issue is confirmed as a bug. area/ticdc Issues or PRs related to TiCDC. labels Feb 21, 2022
@3AceShowHand 3AceShowHand self-assigned this Feb 21, 2022
@3AceShowHand 3AceShowHand mentioned this issue Feb 21, 2022
Merged
@3AceShowHand 3AceShowHand added needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. and removed may-affects-5.4 labels Feb 22, 2022
ti-chi-bot pushed a commit that referenced this issue Feb 22, 2022
@3AceShowHand
cdc/codec: fix string for unsigned value in canal-json. (#4629)
e4ef2b2 
close #4635
@ti-chi-bot ti-chi-bot mentioned this issue Feb 22, 2022
Closed
@jebter jebter added affects-5.4 and removed needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. labels Feb 24, 2022
@3AceShowHand 3AceShowHand mentioned this issue Mar 2, 2022
Closed
4 tasks
3AceShowHand added a commit to ti-chi-bot/tiflow that referenced this issue Apr 11, 2022
@3AceShowHand
cdc/codec: fix string for unsigned value in canal-json. (pingcap#4629)
4362442 
close pingcap#4635
3AceShowHand added a commit to 3AceShowHand/tiflow that referenced this issue Apr 11, 2022
@3AceShowHand
cdc/codec: fix string for unsigned value in canal-json. (pingcap#4629)
e644636 
close pingcap#4635
This was referenced Apr 11, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@3AceShowHand 3AceShowHand

Labels
affects-5.4 area/ticdc Issues or PRs related to TiCDC. component/sink Sink component. severity/critical type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cdc/codec: fix string for unsigned value in canal-json. 3AceShowHand/tiflow
4 participants
@overvenus @jebter @3AceShowHand @ti-chi-bot