mounter(ticdc): timezone fill default value should also consider tz. #10932

3AceShowHand · 2024-04-19T08:18:41Z

What problem does this PR solve?

Issue Number: close #10931

What is changed and how it works?

Ensure to correctly set the default value for the timestamp. It's in UTC and needs to be changed to the timezone set by TiCDC.

Check List

Tests

Unit test
Integration test

Questions

Will it cause performance regression or break compatibility?

Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`

3AceShowHand · 2024-04-19T09:36:56Z

/retest

codecov · 2024-04-19T10:32:41Z

Codecov Report

Merging #10932 (538fa51) into master (0ffc857) will increase coverage by 0.4151%.
Report is 7 commits behind head on master.
The diff coverage is 75.0000%.

Additional details and impacted files

Components	Coverage Δ
cdc	`62.4612% <75.0000%> (+0.7359%)`	⬆️
dm	`51.2838% <ø> (+0.0424%)`	⬆️
engine	`63.4091% <ø> (ø)`

Flag	Coverage Δ
unit	`57.8327% <75.0000%> (+0.4151%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #10932        +/-   ##
================================================
+ Coverage   57.4176%   57.8327%   +0.4151%     
================================================
  Files           850        854         +4     
  Lines        125141     126347      +1206     
================================================
+ Hits          71853      73070      +1217     
+ Misses        47891      47881        -10     
+ Partials       5397       5396         -1

3AceShowHand · 2024-04-19T10:47:18Z

/retest

3AceShowHand · 2024-04-22T03:29:25Z

/retest

hongyunyan

LGTM

ti-chi-bot · 2024-04-23T02:12:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, hongyunyan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [asddongmen,hongyunyan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2024-04-23T02:12:11Z

[LGTM Timeline notifier]

Timeline:

2024-04-22 10:13:10.005121871 +0000 UTC m=+851409.116168336: ☑️ agreed by asddongmen.
2024-04-23 02:12:10.635589114 +0000 UTC m=+53487.375492027: ☑️ agreed by hongyunyan.

3AceShowHand · 2024-04-23T03:18:19Z

/retest

CharlesCheung96 · 2024-04-23T03:29:19Z

Is there any change in compatibility? If there is any change, please explain it in the pr body and add the release-note.

3AceShowHand · 2024-04-23T03:57:15Z

/retest

ti-chi-bot · 2024-04-23T04:27:48Z

In response to a cherrypick label: new pull request created to branch release-6.5: #10946.

Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot · 2024-04-23T04:28:26Z

In response to a cherrypick label: new pull request created to branch release-7.1: #10947.

Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot · 2024-04-23T04:29:03Z

In response to a cherrypick label: new pull request created to branch release-7.5: #10948.

ti-chi-bot · 2024-04-23T04:29:39Z

In response to a cherrypick label: new pull request created to branch release-8.0: #10949.

3AceShowHand · 2024-04-24T03:42:17Z

/cherry-pick release-8.1

ti-chi-bot · 2024-04-24T03:42:25Z

In response to a cherrypick label: new pull request created to branch release-8.1: #10963.

ti-chi-bot · 2024-04-24T03:43:01Z

@3AceShowHand: new pull request could not be created: failed to create pull request against pingcap/tiflow#release-8.1 from head ti-chi-bot:cherry-pick-10932-to-release-8.1: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-10932-to-release-8.1."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

…10932) (#10963) close #10931

…10932) (#10947) close #10931

…10932) (#10948) close #10931

…10932) (#10946) close #10931

commit c092599 Author: Ti Chi Robot <[email protected]> Date: Wed Jun 12 00:26:59 2024 +0800 pkg/config, sink(ticdc): support output raw change event for mq and cloud storage sink (pingcap#11226) (pingcap#11290) close pingcap#11211 commit 3426e46 Author: Ti Chi Robot <[email protected]> Date: Tue Jun 11 19:40:29 2024 +0800 puller(ticdc): fix wrong update splitting behavior after table scheduling (pingcap#11269) (pingcap#11282) close pingcap#11219 commit 2a28078 Author: Ti Chi Robot <[email protected]> Date: Tue Jun 11 16:40:37 2024 +0800 mysql(ticdc): remove error filter when check isTiDB in backend init (pingcap#11214) (pingcap#11261) close pingcap#11213 commit 2425d54 Author: Ti Chi Robot <[email protected]> Date: Tue Jun 11 16:40:30 2024 +0800 log(ticdc): Add more error query information to the returned error to facilitate users to know the cause of the failure (pingcap#10945) (pingcap#11257) close pingcap#11254 commit 053cdaf Author: Ti Chi Robot <[email protected]> Date: Tue Jun 11 15:34:30 2024 +0800 cdc: log slow conflict detect every 60s (pingcap#11251) (pingcap#11287) close pingcap#11271 commit 327ba7b Author: Ti Chi Robot <[email protected]> Date: Tue Jun 11 11:42:00 2024 +0800 redo(ticdc): return internal error in redo writer (pingcap#11011) (pingcap#11091) close pingcap#10124 commit d82ae89 Author: Ti Chi Robot <[email protected]> Date: Mon Jun 10 22:28:29 2024 +0800 ddl_puller (ticdc): handle dorp pk/uk ddl correctly (pingcap#10965) (pingcap#10981) close pingcap#10890 commit f15bec9 Author: Ti Chi Robot <[email protected]> Date: Fri Jun 7 16:16:28 2024 +0800 redo(ticdc): enable pprof and set memory limit for redo applier (pingcap#10904) (pingcap#10996) close pingcap#10900 commit ba50a0e Author: Ti Chi Robot <[email protected]> Date: Wed Jun 5 19:58:26 2024 +0800 test(ticdc): enable sequence test (pingcap#11023) (pingcap#11037) close pingcap#11015 commit 94b9897 Author: Ti Chi Robot <[email protected]> Date: Wed Jun 5 17:08:56 2024 +0800 mounter(ticdc): timezone fill default value should also consider tz. (pingcap#10932) (pingcap#10946) close pingcap#10931 commit a912d33 Author: Ti Chi Robot <[email protected]> Date: Wed Jun 5 10:49:25 2024 +0800 mysql (ticdc): Improve the performance of the mysql sink by refining the transaction event batching logic (pingcap#10466) (pingcap#11242) close pingcap#11241 commit 6277d9a Author: dongmen <[email protected]> Date: Wed May 29 20:13:22 2024 +0800 kvClient (ticdc): revert e5999e3 to remove useless metrics (pingcap#11184) close pingcap#11073 commit 54e93ed Author: dongmen <[email protected]> Date: Wed May 29 17:43:22 2024 +0800 syncpoint (ticdc): make syncpoint support base64 encoded password (pingcap#11162) close pingcap#10516 commit 0ba9329 Author: Ti Chi Robot <[email protected]> Date: Wed May 29 09:07:21 2024 +0800 (redo)ticdc: fix the event orderliness in redo log (pingcap#11117) (pingcap#11180) close pingcap#11096 Signed-off-by: qupeng <[email protected]>

timezone default value should also consider tz.

4d3387b

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 19, 2024

fix test.

a93dc0e

fix ut

538fa51

3AceShowHand requested review from asddongmen, sdojjy and flowbehappy April 22, 2024 09:15

asddongmen approved these changes Apr 22, 2024

View reviewed changes

ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Apr 22, 2024

hongyunyan approved these changes Apr 23, 2024

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 23, 2024

ti-chi-bot bot merged commit e61d080 into pingcap:master Apr 23, 2024
28 checks passed

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Apr 23, 2024

This is an automated cherry-pick of pingcap#10932

89920c0

Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot mentioned this pull request Apr 23, 2024

mounter(ticdc): timezone fill default value should also consider tz. (#10932) #10946

Merged

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Apr 23, 2024

This is an automated cherry-pick of pingcap#10932

76c31f1

Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot mentioned this pull request Apr 23, 2024

mounter(ticdc): timezone fill default value should also consider tz. (#10932) #10947

Merged

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Apr 23, 2024

This is an automated cherry-pick of pingcap#10932

5695d4f

Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot mentioned this pull request Apr 23, 2024

mounter(ticdc): timezone fill default value should also consider tz. (#10932) #10948

Merged

ti-chi-bot mentioned this pull request Apr 23, 2024

mounter(ticdc): timezone fill default value should also consider tz. (#10932) #10949

Open

3AceShowHand added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Apr 24, 2024

ti-chi-bot mentioned this pull request Apr 24, 2024

mounter(ticdc): timezone fill default value should also consider tz. (#10932) #10963

Merged

ti-chi-bot bot pushed a commit that referenced this pull request Apr 24, 2024

mounter(ticdc): timezone fill default value should also consider tz. (#…

26a6350

…10932) (#10963) close #10931

ti-chi-bot bot pushed a commit that referenced this pull request Apr 26, 2024

mounter(ticdc): timezone fill default value should also consider tz. (#…

4757596

…10932) (#10947) close #10931

ti-chi-bot bot pushed a commit that referenced this pull request Apr 26, 2024

mounter(ticdc): timezone fill default value should also consider tz. (#…

2d2748e

…10932) (#10948) close #10931

3AceShowHand mentioned this pull request May 21, 2024

Default value may cause more data inconsistency #4048

Closed

7 tasks

ti-chi-bot bot pushed a commit that referenced this pull request Jun 5, 2024

mounter(ticdc): timezone fill default value should also consider tz. (#…

94b9897

…10932) (#10946) close #10931

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mounter(ticdc): timezone fill default value should also consider tz. #10932

mounter(ticdc): timezone fill default value should also consider tz. #10932

3AceShowHand commented Apr 19, 2024 •

edited by asddongmen

Loading

3AceShowHand commented Apr 19, 2024

codecov bot commented Apr 19, 2024 •

edited

Loading

3AceShowHand commented Apr 19, 2024

3AceShowHand commented Apr 22, 2024

hongyunyan left a comment

ti-chi-bot bot commented Apr 23, 2024

ti-chi-bot bot commented Apr 23, 2024

3AceShowHand commented Apr 23, 2024

CharlesCheung96 commented Apr 23, 2024 •

edited

Loading

3AceShowHand commented Apr 23, 2024

ti-chi-bot commented Apr 23, 2024

ti-chi-bot commented Apr 23, 2024

ti-chi-bot commented Apr 23, 2024

ti-chi-bot commented Apr 23, 2024

3AceShowHand commented Apr 24, 2024

ti-chi-bot commented Apr 24, 2024

ti-chi-bot commented Apr 24, 2024

mounter(ticdc): timezone fill default value should also consider tz. #10932

mounter(ticdc): timezone fill default value should also consider tz. #10932

Conversation

3AceShowHand commented Apr 19, 2024 • edited by asddongmen Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

Questions

Will it cause performance regression or break compatibility?

Do you need to update user documentation, design documentation or monitoring documentation?

Release note

3AceShowHand commented Apr 19, 2024

codecov bot commented Apr 19, 2024 • edited Loading

Codecov Report

3AceShowHand commented Apr 19, 2024

3AceShowHand commented Apr 22, 2024

hongyunyan left a comment

Choose a reason for hiding this comment

ti-chi-bot bot commented Apr 23, 2024

ti-chi-bot bot commented Apr 23, 2024

[LGTM Timeline notifier]

3AceShowHand commented Apr 23, 2024

CharlesCheung96 commented Apr 23, 2024 • edited Loading

3AceShowHand commented Apr 23, 2024

ti-chi-bot commented Apr 23, 2024

ti-chi-bot commented Apr 23, 2024

ti-chi-bot commented Apr 23, 2024

ti-chi-bot commented Apr 23, 2024

3AceShowHand commented Apr 24, 2024

ti-chi-bot commented Apr 24, 2024

ti-chi-bot commented Apr 24, 2024

3AceShowHand commented Apr 19, 2024 •

edited by asddongmen

Loading

codecov bot commented Apr 19, 2024 •

edited

Loading

CharlesCheung96 commented Apr 23, 2024 •

edited

Loading